Change Ordering of the Default Config Directories #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* since darwin doesn't have distinct data and config directories, assumptions that we had were invalid * now the `HOME` config directory is loaded before the system config directory, in this case populating the data directory doesn't invalidate possible user configuration, because the configuration directory now exists
a-kenji
force-pushed
the
darwin-config-dir
branch
from
138c55e
to
1859abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #485
since darwin doesn't have distinct data and config
directories, assumptions that we had were invalid
now the
HOMEconfig directory is loaded before thesystem config directory, in this case populating the
data directory doesn't invalidate possible user configuration,
because the configuration directory now exists