-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Include Ignored Toggle to File Finder and implement support for SearchOption flags on other Pickers #9760
Conversation
Add support for search options for all picker delegates, and add the include ignore option for the file_finder delegate which lets you search files and toggle if you want to show results for files that are ignored
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Alex Kennedy.
|
Updated email. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for an attempt, the inner icon approach looks like one of the good ways to explore for sure, but this alone cannot close #4745 despite stating that.
I've posted a long description in the issue:
#4745 (comment)
what's related to this approach: using the new icon would not show any gitignored files inside directories what were never expanded before:
and adding all gitignored files inside current Zed caches is hard, if possible at all.
I think before adding the toggle, we need to somehow approach the "actually look up all gitignored files we want" issue first, and then come back here (or with another approach if the toggle would not work).
I will close this, as it's inactive for a while and needs a totally different change first to make this PR to work properly and show matches over all ignored files. Thank you for an attempt nonetheless: that button in the input looks like a nice thing to add into a few our pickers, it was great to play with it implemented. |
Closes #4745
Add support to include ignored for the file finder. As a side product, all other picker delegates have the initial seeds planted for adding search options later, if requested or needed.
Open to any and all feedback. New contributor.
Release Notes:
Added (#4745 ).