Add Include Ignored Toggle to File Finder and implement support for SearchOption flags on other Pickers #9677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for search options for all picker delegates, and add the include ignore option for the file_finder delegate which lets you search files and toggle if you want to show results for files that are ignored
|
We require contributors to sign our Contributor License Agreement, and we don't have @alex-astronomer on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Just took a look again and realized that in all of the PickerDelegate implementations that I changed, I could just move that code to the default for the trait. I'll get that changed. |
|
Close since I uploaded with my other non-professional account #9760 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4745
Add support to include ignored for the file finder. As a side product, all other picker delegates have the initial seeds planted for adding search options later, if requested or needed.
Open to any and all feedback. New contributor.
Release Notes: