Skip to content

Add syntax highlighting and LSP for Dockerfiles(#6905)#7977

Merged
SomeoneToIgnore merged 2 commits intozed-industries:mainfrom
d1y:dockerfile
Feb 18, 2024
Merged

Add syntax highlighting and LSP for Dockerfiles(#6905)#7977
SomeoneToIgnore merged 2 commits intozed-industries:mainfrom
d1y:dockerfile

Conversation

@d1y
Copy link
Contributor

@d1y d1y commented Feb 18, 2024

Release Notes:

  • Added Dockerfile syntax highlighting and LSP support

Co-Authored-By: Bryce Palmer <bpalmer@redhat.com>
Co-Authored-By: Kirill Bulatov <mail4score@gmail.com>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 18, 2024
@d1y
Copy link
Contributor Author

d1y commented Feb 18, 2024

In #6905, I can't wait, I need this so much

@d1y
Copy link
Contributor Author

d1y commented Feb 18, 2024

I think when the plugin system is truly perfected, it can be downgraded to the plugin level, but before that, I need it 🤒

@SomeoneToIgnore
Copy link
Contributor

I see that people actually submit extensions already, here's one for Java, for example: zed-industries/extensions#57

Would it make sense to transfer it there?

@d1y
Copy link
Contributor Author

d1y commented Feb 18, 2024

I see that people actually submit extensions already, here's one for Java, for example: zed-industries/extensions#57

Would it make sense to transfer it there?

The current plug-in system is not perfect enough, lsp-server does not support it yet (I am not sure, at least I have not seen anything that does this, and embeds a binary (re-exec)

maxdeviant pushed a commit to zed-industries/extensions that referenced this pull request Feb 18, 2024
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, re-checked on extensions (and noticed no LSP support yet) and this PR (seems good, and LSP actually doing navigation & formatting, so sort of useful).

Let's get that in, thank you for the pushing it over the last mile.

@SomeoneToIgnore SomeoneToIgnore merged commit 12b12ba into zed-industries:main Feb 18, 2024
@d1y d1y deleted the dockerfile branch February 19, 2024 12:45
adorabilis pushed a commit to adorabilis/zed-extensions that referenced this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants