Java support

[louni-longheval]

No description provided.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have @samuser107 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[louni-longheval]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[maxdeviant]

The extension needs to referenced via a Git submodule.

[maxdeviant]

@samuser107 Hmm, the submodule reference doesn't look quite right.

There should be a separate repository containing just the contents of the java extension, and that is what needs to be added as a Git submodule.

For example, here's how we do it with our Nushell extension: https://github.com/zed-extensions/nu

[louni-longheval]

I think it's alright now

[maxdeviant]

Looks like we're failing to build the WASM grammar now.

Is there a reason you went with https://github.com/serenadeai/java-tree-sitter as the Tree-sitter grammar instead of this one from the Tree-sitter org?

https://github.com/tree-sitter/tree-sitter-java

[maxdeviant]

Looks like we're failing to build the WASM grammar now.

Is there a reason you went with https://github.com/serenadeai/java-tree-sitter as the Tree-sitter grammar instead of this one from the Tree-sitter org?

https://github.com/tree-sitter/tree-sitter-java

Actually, it looks like https://github.com/serenadeai/java-tree-sitter isn't even a Tree-sitter grammar for Java, it's Java bindings to Tree-sitter.

[maxdeviant]

Could we also change the extension name to just "Java"?

https://github.com/samuser107/zed-java-extension/blob/2482bd4760c39a275a003e70e8a1bb272cf9d99c/extension.json#L2

The "for Zed" isn't necessary, as this is a Zed extension.

[louni-longheval]

Looks like we're failing to build the WASM grammar now.
Is there a reason you went with https://github.com/serenadeai/java-tree-sitter as the Tree-sitter grammar instead of this one from the Tree-sitter org?
https://github.com/tree-sitter/tree-sitter-java

Actually, it looks like https://github.com/serenadeai/java-tree-sitter isn't even a Tree-sitter grammar for Java, it's Java bindings to Tree-sitter.

yes sorry for that. fixed it with the name too

[maxdeviant]

Thanks for working through this!