Enable test-support features for some dev dependencies#46370
Merged
MrSubidubi merged 1 commit intomainfrom Jan 8, 2026
Merged
Conversation
The vim crate's tests depend on git_ui, which transitively depends on recent_projects with test-support enabled. This causes recent_projects to include RemoteConnectionOptions::Mock variant handling. However, git_ui was not enabling its test-support feature, causing compilation failures when the Mock variant was expected but not available. This commit enables the test-support feature for both git_ui and title_bar dev-dependencies in the vim crate, ensuring the Mock variant is consistently available during testing.
cla-bot
bot
added
the
cla-signed
Veykril
approved these changes
Jan 8, 2026
dinocosta
changed the title
baldwindavid
added a commit
to baldwindavid/zed
that referenced
this pull request
Jan 8, 2026
* main: (349 commits) component_preview: Fix license symlink (zed-industries#46379) Do not react on already observed buffer edits' versions (zed-industries#46308) Fix EP CLI output flicker (zed-industries#46313) vim: Fix bug where repeat operator could lead to unrecoverable replaying state (zed-industries#46376) vim: Implement text-based matching bracket logic for Vim '%' motion to correctly find pairs within comments (zed-industries#45559) Improve LSP button error message (zed-industries#46377) agent: Make reject/accept keybindings consistent with restore/stage (zed-industries#46373) Enable test-support features for some dev dependencies (zed-industries#46370) Capture terminal output when thread is interrupted (zed-industries#46306) Inline assistant tools: no more feature flag (zed-industries#46107) Add `ep split` subcommand for dataset splitting (zed-industries#46364) lsp_button: Fix long LSP version label (zed-industries#46359) remote: Introduce a proper mock remote connection (zed-industries#46337) ep: Allow matching patches against files without trailing newlines (zed-industries#46357) docs: Update "Custom Keybindings for Extension-Based Agents section" to include a troubleshooting note for defining an agent name (zed-industries#46144) Fail early if clangd is downloaded on aarch Linux (zed-industries#46346) ep: Handle errored requests in Anthropic batches (zed-industries#46351) settings_ui: Fix settings search missing results when BM25 finds partial matches (zed-industries#46349) workspace: Unpreview active tab when closing other tabs (zed-industries#46294) terminal: Skip SHLVL when loading login shell environment (zed-industries#46273) ...
rtfeldman
pushed a commit
that referenced
this pull request
Jan 8, 2026
The `vim` crate's tests depend on `git_ui`, which transitively depends on `recent_projects` with `test-support` enabled. This causes `recent_projects` to include RemoteConnectionOptions::Mock` variant handling. However, `git_ui` was not enabling its `test-support` feature, causing compilation failures when the Mock variant was expected but not available. This commit enables the `test-support` feature for both `git_ui` and `title_bar` dev-dependencies in the `vim` crate, ensuring the Mock variant is consistently available during testing. Release Notes: - N/A
rtfeldman
pushed a commit
that referenced
this pull request
Jan 9, 2026
The `vim` crate's tests depend on `git_ui`, which transitively depends on `recent_projects` with `test-support` enabled. This causes `recent_projects` to include RemoteConnectionOptions::Mock` variant handling. However, `git_ui` was not enabling its `test-support` feature, causing compilation failures when the Mock variant was expected but not available. This commit enables the `test-support` feature for both `git_ui` and `title_bar` dev-dependencies in the `vim` crate, ensuring the Mock variant is consistently available during testing. Release Notes: - N/A
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…s#46370) The `vim` crate's tests depend on `git_ui`, which transitively depends on `recent_projects` with `test-support` enabled. This causes `recent_projects` to include RemoteConnectionOptions::Mock` variant handling. However, `git_ui` was not enabling its `test-support` feature, causing compilation failures when the Mock variant was expected but not available. This commit enables the `test-support` feature for both `git_ui` and `title_bar` dev-dependencies in the `vim` crate, ensuring the Mock variant is consistently available during testing. Release Notes: - N/A
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…s#46370) The `vim` crate's tests depend on `git_ui`, which transitively depends on `recent_projects` with `test-support` enabled. This causes `recent_projects` to include RemoteConnectionOptions::Mock` variant handling. However, `git_ui` was not enabling its `test-support` feature, causing compilation failures when the Mock variant was expected but not available. This commit enables the `test-support` feature for both `git_ui` and `title_bar` dev-dependencies in the `vim` crate, ensuring the Mock variant is consistently available during testing. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
vimcrate's tests depend ongit_ui, which transitively depends onrecent_projectswithtest-supportenabled. This causesrecent_projectsto include RemoteConnectionOptions::Mockvariant handling. However,git_uiwas not enabling itstest-support` feature, causing compilation failures when the Mock variant was expected but not available.This commit enables the
test-supportfeature for bothgit_uiandtitle_bardev-dependencies in thevimcrate, ensuring the Mock variant is consistently available during testing.Release Notes: