Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement grapheme support for supermaven completions #18279

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Implement grapheme support for supermaven completions #18279

merged 1 commit into from
Sep 24, 2024

Conversation

s3bba
Copy link
Contributor

@s3bba s3bba commented Sep 24, 2024

Closes #18278

Release Notes:

  • Fixed a panic when graphemes are included in supermaven completions

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 24, 2024
@zed-industries-bot
Copy link

Messages
📖

This PR includes links to the following GitHub Issues: #18278
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against fed1e6f

@s3bba
Copy link
Contributor Author

s3bba commented Sep 24, 2024

This PR was tested on linux, I would appreciate if somebody more familiar with supermaven crate could double check if my grapheme support patch works without regressions.

@notpeter
Copy link
Member

See also:

@notpeter notpeter mentioned this pull request Sep 24, 2024
Closed
1 task
@ConradIrwin ConradIrwin self-assigned this Sep 24, 2024
@ConradIrwin
Copy link
Member

Thanks for this!

@ConradIrwin ConradIrwin merged commit e87d6da into zed-industries:main Sep 24, 2024
9 checks passed
This was referenced Sep 24, 2024
Closed
Closed
@notpeter notpeter mentioned this pull request Sep 24, 2024
Closed
1 task
@ConradIrwin
Copy link
Member

/cherry-pick v0154.x

notpeter pushed a commit that referenced this pull request Sep 25, 2024
@s3bba @notpeter
Implement grapheme support for supermaven completions (#18279)
b2ee628 
Closes [#18278](#18278)

Release Notes:

- Fixed a panic when graphemes are included in supermaven completions
@notpeter
Copy link
Member

@ConradIrwin This was missed by the cherry pick bot. I'm pushing a hotfix release to stable which includes it.

@notpeter notpeter mentioned this pull request Sep 25, 2024
Closed
1 task
ahmadziahidary
ahmadziahidary reviewed Sep 27, 2024
View reviewed changes
Copy link

@ahmadziahidary ahmadziahidary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issues

@s3bba
Copy link
Contributor Author

s3bba commented Sep 28, 2024

Security issues

Care to elaborate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadziahidary ahmadziahidary ahmadziahidary left review comments

Assignees

@ConradIrwin ConradIrwin

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supermaven: Completions with graphemes will cause a panic
5 participants
@s3bba @zed-industries-bot @notpeter @ConradIrwin @ahmadziahidary