Supermaven index fixes #18235
Closed
Supermaven index fixes #18235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
Yes, your approach does seem more reasonable. However, I’m still encountering a crash during testing. Steps to reproduce:
You can look at the video I upload in #18121 to see how it should be like. |
|
I’m super busy recently. I’m currently participating in a competition with tight deadlines and heavy workloads, leaving me with almost no rest. So after submitting PR #18121, I haven't made any further changes. If you're okay with it, I should have plenty of time to address this issue in about two days. |
This was referenced Sep 24, 2024
|
Superseded by #18279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes: #18121
@JunkuiZhang, I think this fixes the problem by always indexing into the char arrays, but please let me know if not
Release Notes: