ruby: Adjust language servers languages #15297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the "language" field to the "languages" field because the `language` field is deprecated. Additionally, allow the Ruby LSP to run in `*.erb` files. Release Notes: - N/A
cla-bot
bot
added
the
cla-signed
vitallium
commented
Jul 26, 2024
| [language_servers.solargraph] | ||
| name = "Solargraph" | ||
| language = "Ruby" | ||
| languages = ["Ruby"] |
Contributor
Author
There was a problem hiding this comment.
Solargraph does not support ERB templates.
vitallium
commented
Jul 26, 2024
| [language_servers.rubocop] | ||
| name = "Rubocop" | ||
| language = "Ruby" | ||
| languages = ["Ruby"] |
Contributor
Author
There was a problem hiding this comment.
Rubocop does not support ERB templates because there is erb-lint linter that utilises rubocop under the hood.
Merged
maxdeviant
added a commit
that referenced
this pull request
Aug 6, 2024
ruby: Bump extension version to v0.1.0 Why not v0.0.9? I think the Ruby extension is mature, and it's time to release the first minor version. But I am totally OK with changing it to 0.0.9. Included changes: - #15778 - #15762 - #15110 - #15297 Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
notpeter
pushed a commit
to zed-extensions/ruby
that referenced
this pull request
Oct 11, 2024
Hi. This is a small pull request that changes the "language" field to the "languages" field because the `language` field is deprecated. Additionally, allow the Ruby LSP to run in `*.erb` files. Release Notes: - N/A
notpeter
pushed a commit
to zed-extensions/ruby
that referenced
this pull request
Oct 11, 2024
Bump extension version to v0.1.0 Why not v0.0.9? I think the Ruby extension is mature, and it's time to release the first minor version. But I am totally OK with changing it to 0.0.9. Included changes: - zed-industries/zed#15778 - zed-industries/zed#15762 - zed-industries/zed#15110 - zed-industries/zed#15297 Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This is a small pull request that changes the "language" field to the "languages" field
because the
languagefield is deprecated.Additionally, allow the Ruby LSP to run in
*.erbfiles.Release Notes: