Skip to content

[v3] clean up create_array signatures in group/asyncgroup classes #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2024
Merged

[v3] clean up create_array signatures in group/asyncgroup classes #2132

merged 3 commits into from
Aug 30, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Aug 28, 2024

Standardizes on name as the first arg to Array.create.

closes #2112

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman jhamman mentioned this pull request Aug 28, 2024
Closed
@jhamman jhamman changed the title clean up create_array signatures in group/asyncgroup classes [v3] clean up create_array signatures in group/asyncgroup classes Aug 28, 2024
@jhamman jhamman merged commit 0b5483a into zarr-developers:v3 Aug 30, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group.create_array signature doesn't match between sync and async
2 participants
@jhamman @TomAugspurger