Skip to content

Group.create_array signature doesn't match between sync and async #2112

Closed
@TomAugspurger

Description

@TomAugspurger

Zarr version

v3

Numcodecs version

na

Python Version

na

Operating System

na

Installation

na

Description

The signature for AsyncGroup.create_array differs from Group.create_array.

Async:

    async def create_array(
        self,
        path: str,
        shape: ChunkCoords,

and sync

    def create_array(
        self,
        name: str,
        *,
        shape: ChunkCoords,

Steps to reproduce

n/a

Additional output

Do we want these to match in general? If so, it might be worth writing a simple pre-commit hook to check that the signatures match between the two objects.

And in this specific case, is path or name correct?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugPotential issues with the zarr-python library

    Type

    No type

    Projects

    Status

    Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions