Fix build for BSD OSes family #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update file names based on their GOOS, allowing the removal of the explicit build constraint, `// +build`, calls. Additionally, this patch rename the _darwin specific file to _bsd, to allow future addition of BSD systems. Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Even though we don't directly support BSD systems, it doesn't mean we can't help them to build `lab` if the work is pretty small. This patch adds the three officialy supported BSD OSes by golang to the cmd/util_bsd file, since they are pretty close to what we need in lab from darwin (or the other way around? :). Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 54.25% 54.51% +0.25%
==========================================
Files 79 79
Lines 4921 4905 -16
==========================================
+ Hits 2670 2674 +4
+ Misses 1994 1975 -19
+ Partials 257 256 -1
Continue to review full report at Codecov.
|
|
Test done by the issue reporter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request fixes #680 by re-organizing the cmd/util_* files for specific GOOS.
Darwin and *BSD (mostly FreeBSD) share some ground when it comes to kernel API, with that, a good starting point is to add both families in the same file, suffixed by _bsd.
I know it doesn't hold true for every syscall, but for what we need in
labit's good enough.