v0.21.0 fails to build on FreeBSD

[swills]

I'm seeing a build failure on FreeBSD:

github.com/zaquestion/lab/cmd
# github.com/zaquestion/lab/cmd
cmd/util_unix.go:33:9: undefined: syscall.Dup3

Yes, the dup3 syscall exists, but I think you can't access it from go via syscall. I think you have to use x/sys/unix Syscall()

[bmeneg]

@swills I think you meant v0.21.0 in the title right? :)
We don't really support FreeBSD directly, but the fix is pretty straightforward.
Let me prepare an MR for you to test.

[bmeneg]

@swills could you checkout the PR #682 branch and try to build it in your FreeBSD local system?
Just to make sure I'm not missing anything.

[swills]

Seems to fail to build the same way:

github.com/zaquestion/lab/cmd
# github.com/zaquestion/lab/cmd
cmd/util_unix.go:30:9: undefined: syscall.Dup3

[bmeneg]

It seems you're still using the version from this repository.
Could you try the following steps?

$ git remote add bmeneg https://github.com/bmeneguele/lab.git
$ git fetch bmeneg
$ git checkout bmeneg/fix-bsd
$ make build

or, in case you don't want to use make:

$ GO111MODULE=on go build

[swills]

Ah, strange, I applied the patch, but must have missed something. Anyway, builds fine now. (Also, FWIW, FreeBSD does have dup3())

[bmeneg]

@swills ah yes, I was aware of that, but the Golang (1.15) interface doesn't implement it.. and that's the version we're still setting as "default" for running lab. I can revisit this topic once we update for 1.16+.

But hey, many thanks for testing it so quickly :)
I'm was preparing the new release right before I saw your issue here.
It'll be included for v0.22.0.

[swills]

I believe the syscall package in Go is frozen and won't change. You can access the dup3() syscall via x/sys tho.

[bmeneg]

@swills that's a good point actually. Just noticed Deprecated: this package is locked down in the syscall docs.
Well, I think I'm going to revisit it for the next release then. Many thanks for the heads up! :)