Skip to content

configurable resources for logical backup pod template #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 5, 2023
Merged

configurable resources for logical backup pod template #710

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4f8da76
pass only default resources to logical backup pod
FxKu Nov 5, 2019
1ac2982
document change
FxKu Nov 15, 2019
dd6f8fd
Merge branch 'master' into logical-backup-pod-resources
FxKu Nov 26, 2019
2fdd11c
remove duplicate config parameter under wrong key
FxKu Nov 26, 2019
6342ddf
Merge branch 'master' into logical-backup-pod-resources
FxKu Dec 10, 2019
eb4f533
new config options for logical backup resources
FxKu Jan 4, 2023
81bd410
remove obsolete docs
FxKu Jan 4, 2023
4a7c09f
swap limit and request
FxKu Jan 4, 2023
190df18
json not name in opconfig api
FxKu Jan 4, 2023
ea9523c
and omitempty
FxKu Jan 4, 2023
58bc93a
fix unit test for stream comparison
FxKu Jan 4, 2023
a23fa3e
resolve conflicts and move azure backup options
FxKu Jan 5, 2023
f6c6e37
define enum for logical_backup_provider
FxKu Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/administrator.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,12 @@ of the backup cron job.
`cronjobs` resource from the `batch` API group for the operator service account.
See [example RBAC](../manifests/operator-service-account-rbac.yaml)

6. Resources of the backup pod are only determined by the configured
[default values](reference/operator_parameters.md#kubernetes-resource-requests)
not by the values specified in the Postgres cluster manifest. This allows for
choosing lower values for CPU and memory requests/limits than for the database
pods.

## Access to cloud resources from clusters in non-cloud environment

To access cloud resources like S3 from a cluster on bare metal you can use
Expand Down
5 changes: 2 additions & 3 deletions pkg/cluster/k8sres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,9 +1465,8 @@ func (c *Cluster) generateLogicalBackupJob() (*batchv1beta1.CronJob, error) {

c.logger.Debug("Generating logical backup pod template")

// allocate for the backup pod the same amount of resources as for normal DB pods
defaultResources := c.makeDefaultResources()
resourceRequirements, err = generateResourceRequirements(c.Spec.Resources, defaultResources)
// allocate only default resources for the backup pod
resourceRequirements, err = generateResourceRequirements(acidv1.Resources{}, c.makeDefaultResources())
if err != nil {
return nil, fmt.Errorf("could not generate resource requirements for logical backup pods: %v", err)
}
Expand Down