configurable resources for logical backup pod template #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
CyberDem0n,
Jan-M,
RafiaSabih,
avaczi,
erthalion and
sdudoladov
as code owners
|
Any update on when this might get merged? |
Member
Author
|
I talked with @sdudoladov back when I opened this PR. I think he was more in favor for adding another config parameter. I could also think of taking the resources of the Postgres cluster and dividing them by a configurable factor. |
Makc2032
approved these changes
Aug 25, 2020
ToGoBananas
approved these changes
Jan 4, 2023
FxKu
changed the title
Member
|
👍 |
1 similar comment
Member
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one has configured quite hungry pods in the manifest, one still has to consider it for logical backup pods. There's no way to configure it.
By relying only on the default resources it's up to the user to choose adequate requests and limits.Edit 2023: PR has been updated to provide resource config options for logical backup pod template. When not configured default postgres pod resources will be used. In the future we can also provide manifest fields and use the config options as defaults.
fixes #688