[UI] revert index.html base url and provide USE_AWS_INSTANCE_PROFILE example #2403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
Jan-M,
hughcapet,
idanovinda,
jopadi and
sdudoladov
as code owners
FxKu
changed the title
Member
Author
|
@simo9000 FYI |
Member
|
👍 |
1 similar comment
Member
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix breaking change introduced by #2195 to fix #2302.
APP_URL is only needed for authentication endpoints
/loginand/logout. The rest is relative paths. No need to set<base href="{{app_url}}">in UI's index.html.I also noticed that the ingress spec differs from what we use. Changed the
pathTypetoPrefixandpathsto["/"]. Still people need to set an existing host.This PR also adds an example for
USE_AWS_INSTANCE_PROFILEwhich the UI supports but we forgot to expose it. Closes #2381