Repository navigation
chore(github): sync the organization forms and repin commit-lint - #941
Conversation
Deploying zsh with
|
| Latest commit: |
ed430f2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6f4b8ee5.zsh.pages.dev |
| Branch Preview URL: | https://feature-769.zsh.pages.dev |
ss-o
left a comment
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on ed430f2
Findings
No actionable findings.
Scope: the complete diff of ed430f2 against main at e07ad1e: the vendored 01_bug_report.yml and 05_membership.yml, and the commit-lint.yml caller.
Important
Sole-maintainer exception under ADR-0035. The maintainer declared that no second human is available and elected the exception for this pull request at ed430f2. A Copilot review was requested at 2026-10-09T12:20:08Z and no review_requested event for Copilot followed; the cause is unconfirmed. A separate read-only review of the same head ran in a different reviewing session, as ADR-0035 decision 3 requires. Additional automated scrutiny is not a second human.
Note
This review is by the pull request's author. It does not approve deployment or release.
Separate read-only review
Head confirmed as ed430f2 with merge-base e07ad1e (the tip of main). No actionable findings. Vendored forms: all eight organization forms in .github/ISSUE_TEMPLATE are byte-identical to z-shell/.github at 362528e, and the one approved exception, 01_request_documentation.yml, matches its pinned blob. Workflow pin: 6fac3d4 is a full SHA on z-shell/.github main and still the latest commit touching commit-lint.yml; it differs from 64a427d only by removing the concurrency group; the caller passes no inputs and keeps contents: read. Supply chain: 64a427d is on no z-shell/.github branch, so the repin also moves to a commit on main. Limits: the startup failure on 64a427d was not reproduced, and no site build was run.
Validation
- Passed: all checks on ed430f2, including the four required Policy checks, CodeQL, Trunk Code Quality, Org Routing, Validate Corpus and the Cloudflare Pages preview. On the previous head d9cc3b9 (pin
64a427d) Commit Lint ended in a startup failure with no jobs. - Blobs:
01_bug_report.ymlis9847bd7and05_membership.ymlis103bdfb, the organization blobs.
Checklist verdicts and supporting evidence
- Source contracts: met. The wiki carries the organization forms (
vendor_org_forms: truein z-shell/.githubtemplate-exceptions.yml), and the copies match the blobs the community-health audit compares against. - Failure paths: improved. Without the repin, the required Policy checks never report on any wiki pull request.
- Supply chain: met. Full-SHA pin with the interim
# maincomment, onmain; permissions unchanged. - Deployment: no site change expected.
pages-deployment.ymlbuilds and deploys on every push tomain; this diff touches only.github/, which the site build does not read. Themainbuild of the merge commit is checked after merge.
Limits and recovery
- Why
64a427dfails to resolve is inferred (it is on no branch), not confirmed; tracked in z-shell/.github#774. - Recovery: revert the squash commit; the previous forms and pin are restorable from
mainat e07ad1e.
Summary
.github/ISSUE_TEMPLATE/01_bug_report.ymland05_membership.ymlwith byte-for-byte copies of the organization forms at z-shell/.github362528e(blobs9847bd7and103bdfb). The bug form is now project-neutral: affected version, a multi-line environment (Zsh version, OS, loading method), a minimal reproduction fromzsh -for a cleanHOME, actual and expected behavior, and optional additional information. The membership form's two policy links, which returned 404, now resolve.01_request_documentation.ymlis an approved exception and is unchanged, as areconfig.ymland the other vendored forms..github/workflows/commit-lint.ymlfrom z-shell/.github64a427dto6fac3d4(ci: support shared Zi quality workflow contracts .github#765), which drops the called workflow's concurrency group as fix(ci): duplicate edit and push runs leave cancelled required checks that block merges zi#597 requires, and update the caller's comment to match. On64a427dthe Commit Lint run for this pull request ended in a startup failure with no jobs, so the four required Policy checks never reported; on6fac3d4they pass.Refs z-shell/.github#769
Verification
d9cc3b9(pin64a427d), success oned430f2(pin6fac3d4).git rev-parse HEAD:.github/ISSUE_TEMPLATE/01_bug_report.ymland05_membership.ymlprint9847bd7357eec0ce15cc65937f619f17f0ebb55cand103bdfb1133aa97d380b14bc3929faf99a931b16, the organization blobs, after the commit hooks ran..github/GOVERNANCE.mdand.github/CODE_OF_CONDUCT.mdin z-shell/.github.Agent handoff
No handoff needed.