Repository navigation
ci: support shared Zi quality workflow contracts - #765
Merged
Merged
Conversation
ss-o
commented
Oct 8, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: maintainer elected, no Copilot request on 0559e5e
No actionable findings remain. Reviewed the full PR diff against base 49cf5b6, the exemption-removal fix, and integration of the updated attribution policy from main.
This is a maintainer-elected self-review, not independent approval. The maintainer separately authorized merge if the change is sound and repository gates pass.
- Correctness: The unreachable historical-subject exemption and inconsistent Git mock are removed. Commit lint retains incoming-subject validation and the advisory trailer behavior inherited from main. Short metadata checks no longer cancel one another.
- Native validation: Explicit sources reject absolute paths, parent traversal, missing files, and symlink leaves or ancestors. Native syntax and optional compilation accumulate failures; compiled output stays outside the checkout. Empty inventories fail when required. Seven executable workflow tests pass.
- Supply chain and permissions: Remote actions remain pinned. Checkout refs are passed as action inputs; source lists enter the shell through environment variables. CodeQL is limited to Actions analysis with job-scoped permissions. Native and CodeQL concurrency groups are distinct from each other and the intended caller groups.
- Coverage and maintenance: Tests are wired into Setup Zsh Tests, and canonical workflow/testing guidance matches generated consumers. Product behavior tests and supported-version declarations remain consumer-owned; this change does not claim Zi rollout or cross-platform support by itself.
- Local verification: 59 commit-policy checks, seven native-workflow tests, Actionlint on all four changed workflows, and knowledge delivery checks passed on this head. The earlier real-history probe validated 14 non-merge Zi commits without the removed exemption.
- Hosted verification: All 25 reported checks passed on the reviewed head, including Linux/macOS setup matrices, native-workflow regressions, commit policy, CodeQL, links, instruction validation, and org routing. GitHub reports the PR merge state as CLEAN; no review threads are open.
- Limits: Local Trunk remained unavailable without its daemon. No downstream Zi reusable-workflow execution was performed. Browser rendering at desktop and narrow widths was unavailable.
Recovery is a normal revert of this scoped workflow change. Existing immutable consumer pins are unchanged, so downstream adoption remains a separate reviewed change. The stale Zi adoption draft must omit the removed policy-baseline-sha input.
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zi cannot reuse the organization quality workflows without losing extensionless Zsh coverage or exact candidate checks during promotion. Extend the shared workflows so Zi can adopt immutable callers while keeping product behavior tests in Zi.
Refs z-shell/zi#597 for the overlapping required-check cancellation defect. This PR addresses its shared-workflow counterpart; it does not close the Zi issue or claim to deliver the separate Zi adoption and repository settings changes.
Verification
python3 automation/ci/test_zsh_ci.py: 7 tests passed, including invalid sources, empty inventories, symlinks, compilation failures, and failure propagation.bash automation/ci/test-commit-lint-policy.sh: 57 checks passed. The actual commit-message workflow block also validated 14 non-merge commits in Zi range76a1a3d..9609445without a historical exemption.git diff --checkpassed.Agent handoff