Update for stream abstract operations #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Actually, hold off. I think I am going to define EnqueueInReadableStream, CloseReadableStream, and ErrorReadableStream abstract ops, which you can use directly. |
domenic
force-pushed
the
update-for-stream-controller
branch
from
d985640 to
9d18a4b
Compare
In whatwg/streams#311, abstract operations were factored out to allow other specs (like this one) to operate on readable streams more directly. We now use them.
domenic
changed the title
Contributor
Author
|
Updated this PR! |
yutakahirano
added a commit
that referenced
this pull request
Apr 8, 2015
Update for stream abstract operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whatwg/streams#310 changes the signature slightly of the
startmethod used here. This commit updates the usage.I couldn't find error used anywhere, BTW...