Skip to content

Conversation

@yutakahirano
Copy link
Owner

No description provided.

@yutakahirano yutakahirano changed the title Add a link to the stream spec for body teeing (#14). Add a link to the stream spec for body teeing. Apr 8, 2015
@yutakahirano
Copy link
Owner Author

This fixes #14. @domenic, can you take a look?

@domenic
Copy link
Contributor

domenic commented Apr 8, 2015

LGTM. Minor nits: I would do

Let «out1, out2» be TeeReadableStream(the associated readable stream, true)

Justification: TeeReadableStream returns a list, which uses «» instead of [] (which is for arrays), and in #28 I use the function-call-style syntax for abstract ops so using it here to match seems nice.

@annevk
Copy link

annevk commented Apr 8, 2015

However, Fetch currently does not use such syntax...

@domenic
Copy link
Contributor

domenic commented Apr 8, 2015

I mean, Fetch doesn't have abstract operations. In the end it's an integration point between two specs, so you have to pick a calling convention and stick with it.

@annevk
Copy link

annevk commented Apr 8, 2015

Fair, hopefully we can converge on something over time, but I guess once I attempt the merge with Fetch I can call out the differences in notes while we're in a transitional time.

@domenic
Copy link
Contributor

domenic commented Apr 8, 2015

Yeah, I guess I just don't really see a problem with using another spec's notation when calling into another spec, even if that notation is different from what is used internally.

@yutakahirano
Copy link
Owner Author

Thanks, fixed.

@yutakahirano yutakahirano merged commit 34d2ccc into master Apr 10, 2015
@yutakahirano yutakahirano deleted the tee branch April 10, 2015 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants