Changed VID/PID to official values and provided fancy alternative#2
Merged
yuhe00 merged 1 commit intoyuhe00:ergodonefrom Oct 3, 2017
marcostrauss:VID/PID
Merged
Changed VID/PID to official values and provided fancy alternative#2yuhe00 merged 1 commit intoyuhe00:ergodonefrom marcostrauss:VID/PID
yuhe00 merged 1 commit intoyuhe00:ergodonefrom
marcostrauss:VID/PID
Conversation
Owner
|
These changes look good, you should just submit them to the main QMK repo. |
Author
|
I thought you as the official ErgoDone maintainer would be trusted more. Do you know whether one pull request with multiple subjects is better than multiple pull requests? |
Owner
|
I don't think it matters that much, especially for such minor changes. Multiple pull requests are better if they are not closely related 👍 |
yuhe00
pushed a commit
that referenced
this pull request
Apr 27, 2018
* initial commit * - Move layout to readme - Finish first (0) layer * remove cruft * fix ASCII keymap in readme * fix ASCII keymap in readme #2 * fix ASCII keymap in readme * rename layers * use 2 shift layout * rename layers, populate additional layers * final layout (TM) * fix RGB saturation increase position
yuhe00
pushed a commit
that referenced
this pull request
Apr 27, 2018
* QMK Configurator updates for the Pearl 40% Attempt to get the physical layout as displayed in the Configurator more true-to-life. * Bugfixes per mechmerlin "By changing KEYMAP to LAYOUT in the .h file, all the keymaps who rely on KEYMAP are now broken. You need to go into the keymap directory and fix all the keymaps affected by this change. Should just be an issue of renaming KEYMAP to LAYOUT." * Merge pull request #2 from noroadsleft/noroadsleft-patch-20180425 Bugfixes per mechmerlin * keymap.c updates for Pearl -#include "pearl.h" +#QMK_KEYBOARD_H
yuhe00
pushed a commit
that referenced
this pull request
Sep 4, 2018
* first verion of skug * zudvp layer added and new thumb cluster * move del to arrw cluster and switch places of algr and no_circ * first verion of skug * zudvp layer added and new thumb cluster * move del to arrw cluster and switch places of algr and no_circ * rework layouts * Adds SYMB layer toggle to 'ä' Closes #2 Also moves ctrl away from '-' and 'z' to the outer bottom corners and removes redundant SYMB layer binds from there * Adds mouse movement to right hand on ARRW layer Closes qmk#3 * Fix typoed keycodes * planck qwerty nordic * Update README.md * Update README.md * Implemented changes to planck layout requested by drashna * Implemented changes to ergodox layout requested by drashna NOTE: `version.h` is still required.
yuhe00
pushed a commit
that referenced
this pull request
Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.