QMK Configurator update for the Pearl 40%#2810
Merged
drashna merged 8 commits intoqmk:masterfrom Apr 26, 2018
noroadsleft:master
Merged
QMK Configurator update for the Pearl 40%#2810drashna merged 8 commits intoqmk:masterfrom noroadsleft:master
drashna merged 8 commits intoqmk:masterfrom
noroadsleft:master
Conversation
Attempt to get the physical layout as displayed in the Configurator more true-to-life.
QMK Configurator update for the Pearl 40%
Contributor
|
By changing KEYMAP to LAYOUT in the .h file, all the keymaps who rely on KEYMAP are now broken. You need to go into the keymap directory and fix all the keymaps affected by this change. Should just be an issue of renaming KEYMAP to LAYOUT. |
"By changing KEYMAP to LAYOUT in the .h file, all the keymaps who rely on KEYMAP are now broken. You need to go into the keymap directory and fix all the keymaps affected by this change. Should just be an issue of renaming KEYMAP to LAYOUT."
Bugfixes per mechmerlin
Bugfixes per mechmerlin
…dsleft/qmk_firmware into noroadsleft-patch-20180425
Member
|
Also, if you're editing the keymap.c files, could you switch the This does the same thing, but it makes the keymap more "universal", which is part of the point of switching to LAYOUT over keymap. |
-#include "pearl.h" +#QMK_KEYBOARD_H
keymap.c updates for Pearl
Member
|
Awesome, thanks! |
carlpehrson
pushed a commit
to carlpehrson/qmk_firmware
that referenced
this pull request
May 7, 2018
* QMK Configurator updates for the Pearl 40% Attempt to get the physical layout as displayed in the Configurator more true-to-life. * Bugfixes per mechmerlin "By changing KEYMAP to LAYOUT in the .h file, all the keymaps who rely on KEYMAP are now broken. You need to go into the keymap directory and fix all the keymaps affected by this change. Should just be an issue of renaming KEYMAP to LAYOUT." * Merge pull request qmk#2 from noroadsleft/noroadsleft-patch-20180425 Bugfixes per mechmerlin * keymap.c updates for Pearl -#include "pearl.h" +#QMK_KEYBOARD_H
hauleth
pushed a commit
to hauleth/qmk_firmware
that referenced
this pull request
Jan 24, 2019
* QMK Configurator updates for the Pearl 40% Attempt to get the physical layout as displayed in the Configurator more true-to-life. * Bugfixes per mechmerlin "By changing KEYMAP to LAYOUT in the .h file, all the keymaps who rely on KEYMAP are now broken. You need to go into the keymap directory and fix all the keymaps affected by this change. Should just be an issue of renaming KEYMAP to LAYOUT." * Merge pull request qmk#2 from noroadsleft/noroadsleft-patch-20180425 Bugfixes per mechmerlin * keymap.c updates for Pearl -#include "pearl.h" +#QMK_KEYBOARD_H
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt to get the physical layout as displayed in the Configurator more true-to-life. Intend to do more of these once I get more comfortable with QMK source. Having to familiarize myself with
keymap.cs andkeyboard.hs. Just a small update to see if I've done this properly.keyboards/pearl/pearl.hwas also updated to changeKEYMAPtoLAYOUTper instructions received from /u/merlin36 (MechMerlin) on reddit, who stated in a PM thatKEYMAPis deprecated.