-
Notifications
You must be signed in to change notification settings - Fork 10
Entity hub: Small refactor and add product & version #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is too much changes I can split the PR to refactor and adding new entity types. |
kalisp
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working (tested on full SG sync to AYON).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Refactored
BaseEntity
a little to support all common attributes so they don't have to be reimplemented in each entity. Also added basic support for product and version.Additional info
Modified arguments in EntityHub methods and in base classes to make a little bit more sense. That might be backwards incomaptible a little, but as EntityHub is used by services at the first place, it should be ok for them to update code with update of ayon api.
Only remainders are that folder and task types are kept as first argument in
add_new_
methods -> those would couse most damage.Entity hud changes:
parent_id
was renamed to be more specific (e.g.folder_id
in case of task entity).TODOs future PRs
Testing notes: