Skip to content

Entity hub: Small refactor and add product & version #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Nov 22, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Refactored BaseEntity a little to support all common attributes so they don't have to be reimplemented in each entity. Also added basic support for product and version.

Additional info

Modified arguments in EntityHub methods and in base classes to make a little bit more sense. That might be backwards incomaptible a little, but as EntityHub is used by services at the first place, it should be ok for them to update code with update of ayon api.

Only remainders are that folder and task types are kept as first argument in add_new_ methods -> those would couse most damage.

Entity hud changes:

  • In some cases parent_id was renamed to be more specific (e.g. folder_id in case of task entity).

TODOs future PRs

  • Add more helper functions to get product and versions (e.g. by name/version and parent it).
  • Add products as children of folder and versions as children of product.

Testing notes:

  1. First of all existing functionality should work as before - all syncs (ftrack, shotgrid, editorial) should work.
  2. It is possible to create and update products and versions.

@iLLiCiTiT iLLiCiTiT self-assigned this Oct 28, 2024
@iLLiCiTiT
Copy link
Member Author

If there is too much changes I can split the PR to refactor and adding new entity types.

@iLLiCiTiT iLLiCiTiT added the type: enhancement New feature or request label Nov 12, 2024
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working (tested on full SG sync to AYON).

@iLLiCiTiT iLLiCiTiT merged commit 720ef6c into develop Nov 22, 2024
2 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancemet/entity-hub-update branch November 22, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants