[DRAFT] Initial support for Version entities in Entity Hub #158

fabiaserra · 2024-06-04T21:55:14Z

Start the work required to support Version entities on the Entity Hub so we will be able to update its status or other attributes.

BigRoy · 2024-06-04T21:57:03Z

Note that you can mark the PR itself as Draft instead of having to put it in the PR title.

~~Also, this PR seems to include #157 - is that intentional?~~ nvm, fixed with 7c90f0b

fabiaserra · 2024-06-04T21:59:38Z

I will let @iLLiCiTiT comment on how we should proceed with this

iLLiCiTiT · 2024-06-04T22:26:22Z

Version entity lives under product entity. It also does not make much sense to add version without representation entity.

Adding any of that to entity hub also changes how hub operates. As far as I know we don't have any huge need for this feature, and too be honest I don't have spare time for that now. You can try to add it on your own.

fabiaserra · 2024-06-04T23:08:26Z

Version entity lives under product entity. It also does not make much sense to add version without representation entity.

Adding any of that to entity hub also changes how hub operates. As far as I know we don't have any huge need for this feature, and too be honest I don't have spare time for that now. You can try to add it on your own.

How are you planning on adding support to sync statuses of Versions across any of the project management tools? Without that version statuses in AYON are useless because people will be expecting to be able to check both databases for ground truth of status, if the one in AYON is not on sync we won't be using it at all and all the places where they see Status in AYON on a version will be distracting and error prone if anyone tries to change it

fabiaserra · 2024-06-05T17:48:37Z

The changes done here 7e7ae67 now allow me to sync statuses on the versions in the ayon-shotgrid plugin

fabiaserra · 2024-06-05T17:49:23Z

ayon_api/entity_hub.py

@@ -2474,6 +2505,7 @@ def from_entity_data(cls, project, entity_hub):
            folder_types=project["folderTypes"],
            task_types=project["taskTypes"],
            name=project["name"],
+            statuses=project["statuses"],


I think this was a bug on the existing code missing statuses for the ProjectEntity

Yes, looks like the method is not used. Will create separate PR.

fabiaserra · 2024-06-05T17:49:53Z

ayon_api/entity_hub.py

@@ -2474,6 +2505,7 @@ def from_entity_data(cls, project, entity_hub):
            folder_types=project["folderTypes"],
            task_types=project["taskTypes"],
            name=project["name"],
+            statuses=project["statuses"],
            attribs=project["ownAttrib"],


@iLLiCiTiT and is this correct? wouldn't it be project["attrib"] instead? and why does ownAttrib not work for the version entity?

Because you set own_attributes=False.

Well like I say on the code, if I set it to True it errors out...

Aaah, I found out that only projects, folders and tasks have ownAttrib will make PR marking the argument deprecated in other methods.

Haha and does that make sense to pass it on as the "attribs" argument on the creator? What would be the equivalent for that for the other entities?

iLLiCiTiT · 2024-06-06T08:49:16Z

How are you planning on adding support to sync statuses of Versions across any of the project management tools?

Well, I guess we never though about syncing versions from other project management. Versions in AYON need product and representations, representations need specific data, how you'll get representation from project management.

fabiaserra · 2024-06-06T09:17:48Z

Well, I guess we never though about syncing versions from other project management. Versions in AYON need product and representations, representations need specific data, how you'll get representation from project management.

Until AYON is able to replace a fully production ready project management tool studios will continue to use those. Version management (status, tags, comments...) will continue to happen mostly in the project manager, if that info doesn't get synced across both, one becomes pointless, and given that AYON is the one lacking most of the features... it's easy to know which one will be.

This is not about creating the versions that are misssing in either, but syncing the data of already created versions on both systems. When a version gets created in AYON a version gets created in SG with a link to it. If I then update the status of that version in SG we need to update that in AYON as well. This PR allows me to do exactly that.

Creating versions (and the corresponding product and representations) would be great as well but that's not a must have.

To your question on how do you get representantion from project management? In SG there's the published files linked to a version that correspond to the representations so it would be easy to map that. In ftrack it's the components of the version... it would definitely be possible

iLLiCiTiT · 2024-06-06T09:23:55Z

To your question on how do you get representantion from project management? In SG there's the published files linked to a version that correspond to the representations so it would be easy to map that. In ftrack it's the components of the version... it would definitely be possible

I'm not talking about files, I'm talking about the rest of the representation entity data.

This is not about creating the versions that are misssing in either, but syncing the data of already created versions on both systems. When a version gets created in AYON a version gets created in SG with a link to it. If I then update the status of that version in SG we need to update that in AYON as well. This PR allows me to do exactly that.

That still requires ProductEntity.

fabiaserra · 2024-06-06T09:27:32Z

I'm not talking about files, I'm talking about the rest of the representation entity data.

Which data? A lot of the data fields are already being set in SG versions, the data that's missing would just be left as default or unset

That still requires ProductEntity.

For what reason? The SG <-> AYON linkage is happening at the version level, I'm updating the version entity directly, what do I need to update on the product?

iLLiCiTiT · 2024-06-06T10:08:13Z

Which data? A lot of the data fields are already being set in SG versions, the data that's missing would just be left as default or unset

Representation entity is not just files, random data would make it unusable, but this PR is about versions, ok.

For what reason? The SG <-> AYON linkage is happening at the version level, I'm updating the version entity directly, what do I need to update on the product?

I do understand but the entity hub is now missing an entity inbetween folder and version.

iLLiCiTiT · 2024-06-06T10:09:00Z

ayon_api/entity_hub.py

+    def __init__(
+        self,
+        *args,
+        tags=None,


We should add task_id.

done at 50e75cd

is comment something passed as an attrib?

fabiaserra · 2024-06-06T10:12:50Z

Representation entity is not just files, random data would make it unusable, but this PR is about versions, ok.

As long as the id gets created and the paths filled up I don't see why it would be completely unusable (the fact that you say it is it worries me the system is more complex than it needs to be) but anyway, it's not the point of this PR nor my intention yet, this is only to allow syncing ALREADY created versions in both systems.

I do understand but the entity hub is now missing an entity inbetween folder and version.

It's missing quite a lot more than just that haha we can add the missing things as soon as they are needed. The product entity is not needed at all for the SG integration

iLLiCiTiT · 2024-06-06T10:32:28Z

It's missing quite a lot more than just that haha we can add the missing things as soon as they are needed. The product entity is not needed at all for the SG integration

I do understand, but that doesn't mean it should not be added.

fabiaserra · 2024-06-06T13:35:12Z

I do understand, but that doesn't mean it should not be added.

Yeah I agree it should be added, but not necessarily part of this PR

iLLiCiTiT · 2024-06-19T15:37:00Z

Yeah I agree it should be added, but not necessarily part of this PR

It should be added before VersionEntity.

fabiaserra · 2024-06-19T17:04:45Z

Yeah I agree it should be added, but not necessarily part of this PR

It should be added before VersionEntity.

Agree to disagree :) it's working fine for me and I'm not missing the product entity at all so I'm not going to work on that to make you guys approve this PR sorry

mkolar · 2024-08-07T17:46:56Z

@iLLiCiTiT we'll soon be starting the work on 2 way full sync for ftrack. Is it worth revisiting this?

iLLiCiTiT · 2024-10-28T17:10:34Z

Closing in favor of #197

farrizabalaga added 2 commits June 4, 2024 23:54

Initial support to update versions through entity hub

b7687ed

Remove changes from feature/task_assignees branch

7c90f0b

fabiaserra marked this pull request as draft June 4, 2024 21:59

Add VersionEntity so we can update its status

7e7ae67

Remove assignees kwarg from version

49792ac

fabiaserra commented Jun 5, 2024

View reviewed changes

Add extra whitespace between classes

993207d

iLLiCiTiT reviewed Jun 6, 2024

View reviewed changes

Add task_id to version entity

50e75cd

fabiaserra mentioned this pull request Jun 6, 2024

AY-7217_Add support to sync task assignees and statuses for all entities ynput/ayon-shotgrid#113

Merged

fabiaserra added 2 commits June 6, 2024 18:41

Merge branch 'develop' into feature/version_entity

0be262a

Revert reverted commit in the history for task assignees

87fe761

iLLiCiTiT closed this Oct 28, 2024

[DRAFT] Initial support for Version entities in Entity Hub #158

[DRAFT] Initial support for Version entities in Entity Hub #158

Uh oh!

Conversation

fabiaserra commented Jun 4, 2024

Uh oh!

BigRoy commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabiaserra commented Jun 4, 2024

Uh oh!

iLLiCiTiT commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabiaserra commented Jun 4, 2024

Uh oh!

fabiaserra commented Jun 5, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iLLiCiTiT Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iLLiCiTiT commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabiaserra commented Jun 6, 2024

Uh oh!

iLLiCiTiT commented Jun 6, 2024

Uh oh!

fabiaserra commented Jun 6, 2024

Uh oh!

iLLiCiTiT commented Jun 6, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabiaserra commented Jun 6, 2024

Uh oh!

iLLiCiTiT commented Jun 6, 2024

Uh oh!

fabiaserra commented Jun 6, 2024

Uh oh!

iLLiCiTiT commented Jun 19, 2024

Uh oh!

fabiaserra commented Jun 19, 2024

Uh oh!

mkolar commented Aug 7, 2024

Uh oh!

iLLiCiTiT commented Oct 28, 2024

Uh oh!

Uh oh!

BigRoy commented Jun 4, 2024 •

edited

Loading

iLLiCiTiT commented Jun 4, 2024 •

edited

Loading

iLLiCiTiT Jun 6, 2024 •

edited

Loading

iLLiCiTiT commented Jun 6, 2024 •

edited

Loading