chore: merge 'main' into 'fall-2025-slot-ify-components' #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benlife5
commented
Oct 31, 2025
benlife5
commented
- re-numbers migrations to account for 2 new migrations on main
- merges the CTA changes made for ref_listings with the CTA changes made for slots
- rebuilds the grid version 28 test
<img width="1221" height="999" alt="Screenshot 2025-10-01 at 1 59 29 PM" src="https://github.com/user-attachments/assets/80cdc2f4-da2f-413b-ad1d-6ac4ba5263d1" /> Confirmed that fonts now load correctly in both the Theme and Layout Editor and match the live page. The problem was that the live page used applyTheme but the editor was only using updateThemeInEditor, so when the font was changed in the editor, the new styles were applied but the actual font files weren't loaded, leading to the editor falling back to defaults. The fix was essentially to just use the applyTheme logic in the editor as well. Test Site: https://www.yext.com/s/4259018/yextsites/160744/theme#themeId=font-test-2&pageSetId=font-test-2&locale=en&entityId=1095527849 --------- Co-authored-by: coltondemetriou <coltondemetriou@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
<img width="550" height="332" alt="Screenshot 2025-10-01 at 4 45 11 PM" src="https://github.com/user-attachments/assets/11927759-652c-49d1-a1b4-85d57ce97bda" /> The problem was when the editor first loaded no google fonts were loaded (only theme-specific fonts), fixed by loading the fonts on initial load. Verified in local dev that the fonts loaded in the editor on the page and in the selector. --------- Co-authored-by: coltondemetriou <coltondemetriou@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
When sending the user's schema to the parent to allow for editing, we now also send the default schema. A new option in the UI will allow the user to restore the default schema and clear any edits they've made. Ran everything locally and logged the payload that was sent to the front-end, confirming that it included the new defaultValue field. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
https://yexttest.atlassian.net/browse/VULN-40342 Verified that all the fonts still render in editor, dropdown, and live page https://www.yext.com/s/4259018/yextsites/160762/theme#themeId=test-vuln-10-2-25&pageSetId=vuln-test&locale=en&entityId=1095527849 --------- Co-authored-by: coltondemetriou <coltondemetriou@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
From Paige's spreadsheet: the color 305af3 (dark blue) was being displayed with black text. The issue was that we updated to a better contrast algorithm in the theme editor but the old algorithm was still being used as a backup in applyTheme. I think the recent changes to applyTheme changed how those two values were resolved and the old algorithm was being preferred. This change fully swaps to the better algorithm and gives saved db contrast colors precedence over the fallback calculation. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Other entity types like "Restaurant" were previously using the basic fallback schema, but any built-in entity type that is a location should be considered as such. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
[slack thread](https://yext.slack.com/archives/C02UVSE7P6W/p1759774392931519) Works in editor and live page. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
<img width="1840" height="1104" alt="Screenshot 2025-10-09 at 3 58 45 PM" src="https://github.com/user-attachments/assets/93c2093f-6fa7-4e77-8ffe-0219126267bd" /> <img width="1840" height="1104" alt="Screenshot 2025-10-09 at 3 57 48 PM" src="https://github.com/user-attachments/assets/3f839a20-ce6f-4123-a387-4e2736f50089" /> Puck 0.20.2 includes a fix for the "Other" category --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
https://github.com/user-attachments/assets/ab992086-993f-4b6e-9fc9-3dd8c3d76b29 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
pages-components has a few css overrides that were being dropped on the live page in the last artifact --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This fixes the phone number link on the locator and changes the text in the search input from "Current Location" to the current location itself when the user searches for locations nearby. Tested and verified that phone links work as expected and the search input is populated correctly.
Only if siteDomain is set + exists will this canonical url tag be added to the head --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
J=WAT-5112 TEST=manual tested in dev mode & live site https://github.com/user-attachments/assets/4622d774-4833-4a6f-95fe-8eea2a3c4c2d --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Alexis Sanehisa <106991746+asanehisa@users.noreply.github.com> Co-authored-by: Alexis Sanehisa <asanehisa@yext.com>
Confirmed timezone was passed everywhere else (Hero, LocatorCard, NearbyLocationCard, DirectoryCard)
The directory meta fields were broken because the default fields are only populated if `root.props` is undefined and `root.props` was partially defined in the defaultLayoutData. This fixed by explicitly adding the title and description fields to the directory and locator layouts. The field and constantValue are both set to `""` -- this might change in the future (https://yext.slack.com/archives/C06A06BCUUF/p1760728433383689?thread_ts=1760724818.768159&cid=C06A06BCUUF) but we don't have the brand name available right now.
Co-authored-by: coltondemetriou <coltondemetriou@gmail.com>
#826) Adds a new field type, `DynamicOptionsSelector`. This field type can be populated with options from a function using hooks, which will allow e.g. reading off the stream document to determine which set of options to show. This PR also uses this type for the `Locator` component's `Dynamic Fields` (facet fields) setting. The actual implementation of the dynamic fields in the component will come in a separate change / commit. J=[WAT-4911](https://yexttest.atlassian.net/browse/WAT-4911?atlOrigin=eyJpIjoiMGEzNzFiYjg1ZDA3NDg1MDliN2ZiZTQwOTdmNTg1ZDQiLCJwIjoiaiJ9) https://github.com/user-attachments/assets/103a6f27-acf3-4950-a7e7-ab2d536243cc --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Life <blife@yext.com>
We were importing by package instead of by file, so treeshaking was not happening. The plugin build is now immensely faster and the output size went from ~8mb to ~8kb. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
J=WAT-5143,WAT-5144 TEST=manual confirmed it worked in dev mode and live pages https://drive.google.com/file/d/172DeYAyBHMZcJQbOiFK5qYThSmHPFAti/view?usp=sharing --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This updates the directory schema to be a `CollectionPage` with the `dm_directoryChildren` as the list elements, adds a new default schema for locators, and fixes the fallback default schema. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
- Allows migrations for root.props - Migrates our current location schemas to set `@id` with the domain and path - Migrates directory and locator schemas based on #845 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
For Get Directions previously using Coordinates: ``` if (ref_listings): build link with ref_listings else: build link with yextDisplayCoordinate ``` For Get Directions previously using Address: ``` if currentlySelectedAddress is address && ref_listings: build link with ref_listings else build link with Address ``` Remove static value from Address prop. Don't allow users to select coordinates to use, always use "yextDisplayCoordinate" Tested in platform and confirmed setting address field to a diff field works. Confirmed ref_listings is used if it exists and gives a valid link. Confirmed fallbacks work as expected. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Automatically add breadcrumbs and reviews schema to entity pages, if the data is present on the document. Breadcrumbs and reviews get added as separate blocks. Wraps the whole schema in `@graph`. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Didn't save on previous commit Co-authored-by: coltondemetriou <coltondemetriou@gmail.com>
Contributor
|
| Key | Languages Removed |
|---|---|
currentLocation |
cs,de en,en-GB es,et fi,fr hr,hu it,ja lt,lv nb,nl pt,ro tr,zh zh-TW |
fields
| Key | Languages Removed |
|---|---|
fields.options.ctaDisplayType.presetImage |
cs,da de,en en-GB,es et,fi fr,hr hu,it ja,lt lv,nb nl,pl pt,ro sk,sv tr,zh zh-TW |
fields.options.ctaDisplayType.textAndLink |
cs,da de,en en-GB,es et,fi fr,hr hu,it ja,lt lv,nb nl,pl pt,ro sk,sv tr,zh zh-TW |
benlife5
changed the title
benlife5
requested review from
asanehisa,
briantstephan,
colton-demetriou and
mkilpatrick
Contributor
Author
|
#840 is going to cause another conflict, although it shouldn't be too bad to resolve |
mkilpatrick
approved these changes
Oct 31, 2025
colton-demetriou
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.