feat: add facets to locator component filter modal#833
Merged
mkouzel-yext merged 70 commits intomainfrom Nov 3, 2025
Merged
Conversation
Contributor
|
Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information. |
mkouzel-yext
commented
Oct 23, 2025
mkouzel-yext
changed the title
benlife5
reviewed
Oct 24, 2025
asanehisa
reviewed
Oct 27, 2025
asanehisa
reviewed
Oct 27, 2025
These tests have been renamed "[*] latest version default props *"
benlife5
reviewed
Oct 31, 2025
Contributor
benlife5
left a comment
benlife5
left a comment
There was a problem hiding this comment.
LGTM other than small nit and Alexis's comment about deleting the old screenshots
Updates the modal to be a child of the main locator panel div and to have a max height of 100vh (minus 32px for 16px margins on the top and bottom)
benlife5
approved these changes
Nov 3, 2025
asanehisa
approved these changes
Nov 3, 2025
mkouzel-yext
added a commit
that referenced
this pull request
Nov 3, 2025
Updates the locator component's filter modal to include the facets selected by the user in the settings panel. Note: A know gap between this commit and the mock is that the checkboxes are gray rather than the primary theme color (in the case of the demo, dark red). That will require additional work in search-ui-react to allow for custom icons for facet options. J=WAT-5141 TEST=manual demo:https://drive.google.com/file/d/1AfRy4-7Ym1OaO_PQoYIj0tagiPoVyFEN/view?usp=drive_link --------- Co-authored-by: Kyle Gerner <kgerner@yext.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Life <blife@yext.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Nov 3, 2025
Merged
Merged
Merged
This was referenced Feb 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the locator component's filter modal to include the facets selected by the user in the settings panel.
Note: A know gap between this commit and the mock is that the checkboxes are gray rather than the primary theme color (in the case of the demo, dark red). That will require additional work in search-ui-react to allow for custom icons for facet options.
J=WAT-5141
TEST=manual
demo:https://drive.google.com/file/d/1AfRy4-7Ym1OaO_PQoYIj0tagiPoVyFEN/view?usp=drive_link