Skip to content

Conversation

@benlife5
Copy link
Contributor

  • handles img sizes for Promo
  • runs resolveAllData when the streamDocument updates -- necessary for entity switching in the editor
  • adds CTA event names for Hero/Promo
  • adds ids to the slot children of the default cards-- solves a problem where sometimes the puck would not automatically add an id, leading to strange rendering

@benlife5 benlife5 changed the title Misc fixes fix: miscellaneous slot bugs Oct 15, 2025
@github-actions
Copy link
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@benlife5 benlife5 merged commit 673cd30 into fall-2025-slot-ify-components Oct 15, 2025
14 checks passed
@benlife5 benlife5 deleted the misc-fixes branch October 15, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants