feat: slot-ify insights section #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 15, 2025 14:54
colton-demetriou
requested review from
asanehisa,
benlife5,
briantstephan and
mkilpatrick
benlife5
reviewed
Oct 15, 2025
Contributor
benlife5
left a comment
benlife5
left a comment
There was a problem hiding this comment.
Looks good, just a few updates to merge in
packages/visual-editor/src/components/pageSections/InsightSection/InsightCard.tsx
Show resolved
Hide resolved
packages/visual-editor/src/components/pageSections/InsightSection/InsightCard.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/pageSections/InsightSection/InsightCard.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/pageSections/InsightSection/InsightCardsWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/pageSections/InsightSection/InsightSection.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/migrations/0030_insight_section_slots.ts
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/pageSections/InsightSection.tsx
Outdated
Show resolved
Hide resolved
added 3 commits
October 15, 2025 18:50
…omponent, useGetCardSlots, cardWrapperFields, forwardHeadingLevel
commit: |
benlife5
reviewed
Oct 16, 2025
packages/visual-editor/src/components/pageSections/InsightSection/InsightCard.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/pageSections/InsightSection/InsightCardsWrapper.tsx
Outdated
Show resolved
Hide resolved
benlife5
reviewed
Oct 16, 2025
packages/visual-editor/src/components/pageSections/InsightSection/InsightSection.test.tsx
Outdated
Show resolved
Hide resolved
benlife5
reviewed
Oct 16, 2025
packages/visual-editor/src/components/pageSections/InsightSection/InsightSection.test.tsx
Show resolved
Hide resolved
added 2 commits
October 16, 2025 11:00
briantstephan
previously approved these changes
Oct 16, 2025
benlife5
reviewed
Oct 16, 2025
...components/testing/screenshots/InsightSection/[desktop] default props with document data.png
Show resolved
Hide resolved
...nents/testing/screenshots/InsightSection/[desktop] version 16 props with missing ctaType.png
Outdated
Show resolved
Hide resolved
...mponents/testing/screenshots/InsightSection/[desktop] version 0 props with entity values.png
Show resolved
Hide resolved
briantstephan
previously approved these changes
Oct 16, 2025
benlife5
reviewed
Oct 17, 2025
...components/testing/screenshots/InsightSection/[desktop] default props with document data.png
Show resolved
Hide resolved
...onents/testing/screenshots/InsightSection/[mobile] version 16 props with missing ctaType.png
Outdated
Show resolved
Hide resolved
added 2 commits
October 17, 2025 14:39
benlife5
reviewed
Oct 17, 2025
packages/visual-editor/src/components/pageSections/InsightSection/InsightCard.tsx
Outdated
Show resolved
Hide resolved
benlife5
approved these changes
Oct 17, 2025
briantstephan
approved these changes
Oct 17, 2025
colton-demetriou
merged commit 16917c1
into
fall-2025-slot-ify-components
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested all functionality of editing fields, theme, drag and drop, etc.