feat: use slots in events section #815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information. |
Contributor
Author
|
^ there was an earlier slots migration for Events Section that I updated rather than creating a new one |
commit: |
asanehisa
reviewed
Oct 14, 2025
packages/visual-editor/src/components/migrations/0023_event_section_slots.ts
Outdated
Show resolved
Hide resolved
asanehisa
reviewed
Oct 14, 2025
packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx
Outdated
Show resolved
Hide resolved
benlife5
requested review from
asanehisa,
briantstephan,
colton-demetriou and
mkilpatrick
mkilpatrick
reviewed
Oct 15, 2025
packages/visual-editor/src/components/contentBlocks/Timestamp.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/contentBlocks/Timestamp.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@mkilpatrick Going to put up the CTA fixes in a separate PR because it's not a small change |
mkilpatrick
approved these changes
Oct 15, 2025
asanehisa
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizesand ctaeventNamefor product section (will do others in separate pr)