chore: merge main into fall-2025-slot-ify-components #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<img width="1221" height="999" alt="Screenshot 2025-10-01 at 1 59 29 PM" src="https://github.com/user-attachments/assets/80cdc2f4-da2f-413b-ad1d-6ac4ba5263d1" /> Confirmed that fonts now load correctly in both the Theme and Layout Editor and match the live page. The problem was that the live page used applyTheme but the editor was only using updateThemeInEditor, so when the font was changed in the editor, the new styles were applied but the actual font files weren't loaded, leading to the editor falling back to defaults. The fix was essentially to just use the applyTheme logic in the editor as well. Test Site: https://www.yext.com/s/4259018/yextsites/160744/theme#themeId=font-test-2&pageSetId=font-test-2&locale=en&entityId=1095527849 --------- Co-authored-by: coltondemetriou <coltondemetriou@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
<img width="550" height="332" alt="Screenshot 2025-10-01 at 4 45 11 PM" src="https://github.com/user-attachments/assets/11927759-652c-49d1-a1b4-85d57ce97bda" /> The problem was when the editor first loaded no google fonts were loaded (only theme-specific fonts), fixed by loading the fonts on initial load. Verified in local dev that the fonts loaded in the editor on the page and in the selector. --------- Co-authored-by: coltondemetriou <coltondemetriou@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
When sending the user's schema to the parent to allow for editing, we now also send the default schema. A new option in the UI will allow the user to restore the default schema and clear any edits they've made. Ran everything locally and logged the payload that was sent to the front-end, confirming that it included the new defaultValue field. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
https://yexttest.atlassian.net/browse/VULN-40342 Verified that all the fonts still render in editor, dropdown, and live page https://www.yext.com/s/4259018/yextsites/160762/theme#themeId=test-vuln-10-2-25&pageSetId=vuln-test&locale=en&entityId=1095527849 --------- Co-authored-by: coltondemetriou <coltondemetriou@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mkilpatrick
approved these changes
Oct 6, 2025
asanehisa
approved these changes
Oct 6, 2025
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.