v1.8.2 - Update MapboxMap with VLE props for using inside an iframe + update workflow yamls #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side an iframe) Update MapboxMap with VLE props for using inside an iframe
k-gerner
changed the title
|
Current unit coverage is 91.95837275307474% |
Fondryext
previously approved these changes
Mar 27, 2025
Fondryext
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added two props to the MapboxMap component: iframeWindow and allowUpdates. These props were added to enable usage of this component in the Visual Layout Editor. Because we are using the component in an iframe, we need to use the iframe's mapboxgl library to properly reference the window. Additionally, the allowUpdates property is used so that we can dynamically change properties / styles of the map through the VLE. Currently, we only allow changing the "style" of the map (such as satellite view, dark mode, etc), but more can be added as necessary. With this property set to true, we will listen to updates to the mapbox options, and update when applicable.
Separately, I have added a navigation button section, which contains + and - buttons for zooming in and out of the map.
Additionally, I have fixed some of the workflows and test cases that were having errors.