Update MapboxMap with VLE props for using inside an iframe #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-gerner
requested review from
vijay267,
anguyen-yext2,
Fondryext and
mkouzel-yext
|
Could you add a little more context to the commit message and perhaps change the title? Going through Slack I think I understand the motivation here but it isn't as clear in the PR proper. |
k-gerner
changed the title
Updated! |
|
Current unit coverage is 91.95837275307474% |
Fondryext
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have added two props to the
MapboxMapcomponent:iframeWindowandallowUpdates. These props were added to enable usage of this component in the Visual Layout Editor. Because we are using the component in an iframe, we need to use the iframe'smapboxgllibrary to properly reference the window. Additionally, theallowUpdatesproperty is used so that we can dynamically change properties / styles of the map through the VLE. Currently, we only allow changing the "style" of the map (such as satellite view, dark mode, etc), but more can be added as necessary. With this property set totrue, we will listen to updates to the mapbox options, and update when applicable.Separately, I have added a navigation button section, which contains
+and-buttons for zooming in and out of the map.