Skip to content

Avoid recompilation of Aggregation Mode by using receipts on the Makefile #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 6, 2025
Merged

Avoid recompilation of Aggregation Mode by using receipts on the Makefile #1962

merged 15 commits into from
Jun 6, 2025

Conversation

MauroToscano
Copy link
Contributor

@MauroToscano MauroToscano commented Jun 3, 2025 •
edited
Loading

Avoid recompilation of Aggregation Mode by using receipts on the Makefile

Description

Avoid recompilation of Aggregation Mode by using receipts on the Makefile. Notice this doesn't include DEV mode

Type of change

Please delete options that are not relevant.

  • New feature

@MauroToscano MauroToscano mentioned this pull request Jun 3, 2025
Closed
14 tasks
JuArce
JuArce requested changes Jun 4, 2025
View reviewed changes
MauroToscano and others added 7 commits June 4, 2025 11:32
@MauroToscano
Add missing wildcards
06b80bd
@MauroToscano
Merge branch 'avoid_recompiling_to_start_aggregator' of github.com:ye…
2f5cf5f 
…tanotherco/aligned_layer into avoid_recompiling_to_start_aggregator
@MauroToscano @JuArce
Update Makefile
7a38f00 
Co-authored-by: Julian Arce <52429267+JuArce@users.noreply.github.com>
@MauroToscano @JuArce
Update Makefile
aafe033 
Co-authored-by: Julian Arce <52429267+JuArce@users.noreply.github.com>
@MauroToscano
Fix targets
12ce00d
@MauroToscano
Move agg mode sources to it's own file
386098b
@MauroToscano
Re order requisites
d40c7b7
JuArce
JuArce requested changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aggregation mode won't recompile if we change something in the cargo.toml

@MarcosNicolau MarcosNicolau requested a review from JuArce June 6, 2025 18:48
@MarcosNicolau
Copy link
Member

Aggregation mode won't recompile if we change something in the cargo.toml

Fixed in 00346cf.

@JuArce JuArce added this pull request to the merge queue Jun 6, 2025
Merged via the queue into staging with commit 3f47eca Jun 6, 2025
3 checks passed
@JuArce JuArce deleted the avoid_recompiling_to_start_aggregator branch June 6, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuArce JuArce JuArce approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

Assignees

@MauroToscano MauroToscano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MauroToscano @MarcosNicolau @JuArce