chore(aggregation-mode): prevent rebuilding programs if not changed #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuArce
reviewed
Jun 2, 2025
| ]; | ||
|
|
||
| for file in &programs { | ||
| println!("cargo:rerun-if-changed={}", file); |
There was a problem hiding this comment.
These prints are not displayed
There was a problem hiding this comment.
Build scripts communicate with Cargo by printing to stdout. Cargo will interpret each line that starts with cargo:: as an instruction that will influence compilation of the package. All other lines are ignored.
These flags indicate that the build.rs should run if the file outputted has been modified. They weren't really working for me that is why the hash solution was applied. Right now, they are there just in case. You can read more in the source.
Source: https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script
JuArce
approved these changes
Jun 2, 2025
|
This should be done with a makefile, I'm making another pr to solve this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we introduced deterministic buildings with docker for the zkvm programs the proof aggregator started to take too much time to compile. This got even worse after the multilayer feature. This pr, recompiles the programs only if they have changed. For that, we've been orthodox and simply solved it by hashing the files + features.
This means that now the programs have to be compiled only once for each feature (prove, gpu)
To test it I suggest removing the
use_dockeroptions for faster builds inbuild.rsType of change
Checklist
testnet, everything else tostaging