streamlookup, generic lookup, yt lookup: remove TUVMap usage from events #9758

yumkam · 2024-09-25T13:56:41Z

Changelog entry

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

Using TUnboxedValueMap in actor system events is UB. Use std::weak_ptr for events and store std::shared_ptr in actors.
Using actors directly after registration is UB. Use events instead.

github-actions · 2024-09-25T13:59:45Z

⚪ 2024-09-25 13:59:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for f4b5b83 has started.
⚪ 2024-09-25 14:00:37 UTC Artifacts will be uploaded here
⚪ 2024-09-25 14:04:07 UTC ya make is running...
🟡 2024-09-25 15:30:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
74605	60674	0	5	13825	101

⚪ 2024-09-25 15:36:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-25 15:48:38 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
109 (only retried tests)	16	0	0	0	93

🟢 2024-09-25 15:48:45 UTC Build successful.
🟢 2024-09-25 15:49:21 UTC ydbd size 8.5 GiB changed* by +26.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `d59377c`	merge: `f4b5b83`	diff	diff %
ydbd size	9 076 657 792 Bytes	9 076 684 400 Bytes	+26.0 KiB	+0.000%
ydbd stripped size	490 716 488 Bytes	490 716 360 Bytes	-128 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-25T14:00:26Z

⚪ 2024-09-25 14:00:25 UTC Pre-commit check linux-x86_64-release-clang14 for f4b5b83 has started.
⚪ 2024-09-25 14:00:52 UTC Artifacts will be uploaded here
⚪ 2024-09-25 14:03:47 UTC ya make is running...
🟢 2024-09-25 14:47:09 UTC Build successful.

github-actions · 2024-09-25T14:00:34Z

⚪ 2024-09-25 14:00:34 UTC Pre-commit check linux-x86_64-release-asan for f4b5b83 has started.
⚪ 2024-09-25 14:00:45 UTC Artifacts will be uploaded here
⚪ 2024-09-25 14:03:49 UTC ya make is running...
🟡 2024-09-25 16:06:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12156	11913	0	41	76	126

🟢 2024-09-25 16:07:29 UTC Build successful.
🟢 2024-09-25 16:08:05 UTC ydbd size 5.7 GiB changed* by +2.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `d59377c`	merge: `f4b5b83`	diff	diff %
ydbd size	6 081 793 032 Bytes	6 081 795 864 Bytes	+2.8 KiB	+0.000%
ydbd stripped size	1 520 304 592 Bytes	1 520 299 280 Bytes	-5.2 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-27T12:16:07Z

⚪ 2024-09-27 12:16:06 UTC Pre-commit check linux-x86_64-release-asan for 639bcb2 has started.
⚪ 2024-09-27 12:17:02 UTC Artifacts will be uploaded here
⚪ 2024-09-27 12:20:35 UTC ya make is running...
🟡 2024-09-27 14:51:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12207	11976	0	47	62	122

🟢 2024-09-27 14:52:45 UTC Build successful.
🟢 2024-09-27 14:53:22 UTC ydbd size 5.7 GiB changed* by +30.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `d2299da`	merge: `639bcb2`	diff	diff %
ydbd size	6 085 684 680 Bytes	6 085 715 984 Bytes	+30.6 KiB	+0.001%
ydbd stripped size	1 521 127 632 Bytes	1 521 134 672 Bytes	+6.9 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-27T12:17:24Z

⚪ 2024-09-27 12:17:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 639bcb2 has started.
⚪ 2024-09-27 12:17:34 UTC Artifacts will be uploaded here
⚪ 2024-09-27 12:20:31 UTC ya make is running...
🟡 2024-09-27 14:02:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
74658	60732	0	3	13824	99

⚪ 2024-09-27 14:09:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-27 14:21:00 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
106 (only retried tests)	14	0	0	0	92

🟢 2024-09-27 14:21:09 UTC Build successful.
🟢 2024-09-27 14:21:45 UTC ydbd size 8.5 GiB changed* by +50.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `d2299da`	merge: `639bcb2`	diff	diff %
ydbd size	9 083 085 648 Bytes	9 083 137 744 Bytes	+50.9 KiB	+0.001%
ydbd stripped size	490 949 128 Bytes	490 954 440 Bytes	+5.2 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-30T11:10:11Z

⚪ 2024-09-30 11:10:11 UTC Pre-commit check linux-x86_64-release-asan for 3193394 has started.
⚪ 2024-09-30 11:10:21 UTC Artifacts will be uploaded here
⚪ 2024-09-30 11:13:24 UTC ya make is running...
⚫ 2024-09-30 11:37:25 UTC Check cancelled

github-actions · 2024-09-30T11:10:59Z

⚪ 2024-09-30 11:10:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3193394 has started.
⚪ 2024-09-30 11:11:09 UTC Artifacts will be uploaded here
⚪ 2024-09-30 11:14:11 UTC ya make is running...
⚫ 2024-09-30 11:37:24 UTC Check cancelled

ydb/library/yql/dq/actors/input_transforms/dq_input_transform_lookup.cpp

github-actions · 2024-09-30T11:38:51Z

⚪ 2024-09-30 11:38:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for e2fb45e has started.
⚪ 2024-09-30 11:39:06 UTC Artifacts will be uploaded here
⚪ 2024-09-30 11:42:01 UTC ya make is running...
🟡 2024-09-30 12:48:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
74658	60736	0	3	13827	92

⚪ 2024-09-30 12:55:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-30 13:06:59 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
96 (only retried tests)	6	0	0	0	90

🟢 2024-09-30 13:07:06 UTC Build successful.
🟢 2024-09-30 13:07:27 UTC ydbd size 2.8 GiB changed* by +27.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `fbe6aca`	merge: `e2fb45e`	diff	diff %
ydbd size	3 001 429 136 Bytes	3 001 457 648 Bytes	+27.8 KiB	+0.001%
ydbd stripped size	477 332 328 Bytes	477 333 544 Bytes	+1.2 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-30T11:41:28Z

⚪ 2024-09-30 11:41:28 UTC Pre-commit check linux-x86_64-release-asan for e2fb45e has started.
⚪ 2024-09-30 11:41:39 UTC Artifacts will be uploaded here
⚪ 2024-09-30 11:44:38 UTC ya make is running...
🟡 2024-09-30 13:48:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12217	11971	0	54	66	126

🟢 2024-09-30 13:49:24 UTC Build successful.
🟢 2024-09-30 13:50:02 UTC ydbd size 5.7 GiB changed* by +30.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `fbe6aca`	merge: `e2fb45e`	diff	diff %
ydbd size	6 085 233 216 Bytes	6 085 264 520 Bytes	+30.6 KiB	+0.001%
ydbd stripped size	1 520 350 960 Bytes	1 520 358 000 Bytes	+6.9 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-30T15:01:29Z

⚪ 2024-09-30 15:01:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for ea1ea9f has started.
⚪ 2024-09-30 15:01:40 UTC Artifacts will be uploaded here
⚪ 2024-09-30 15:04:41 UTC ya make is running...
🟡 2024-09-30 16:17:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
74666	60732	0	3	13825	106

⚪ 2024-09-30 16:24:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-30 16:35:31 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
102 (only retried tests)	7	0	0	1	94

🟢 2024-09-30 16:35:39 UTC Build successful.
🟢 2024-09-30 16:36:01 UTC ydbd size 2.8 GiB changed* by +35.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4454ea3`	merge: `ea1ea9f`	diff	diff %
ydbd size	3 001 595 472 Bytes	3 001 631 752 Bytes	+35.4 KiB	+0.001%
ydbd stripped size	477 347 656 Bytes	477 357 064 Bytes	+9.2 KiB	+0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-30T15:01:36Z

⚪ 2024-09-30 15:01:35 UTC Pre-commit check linux-x86_64-release-asan for ea1ea9f has started.
⚪ 2024-09-30 15:01:45 UTC Artifacts will be uploaded here
⚪ 2024-09-30 15:04:43 UTC ya make is running...
🟡 2024-09-30 17:05:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12213	11980	0	56	52	125

🟢 2024-09-30 17:06:27 UTC Build successful.
🟢 2024-09-30 17:07:00 UTC ydbd size 5.7 GiB changed* by +29.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4454ea3`	merge: `ea1ea9f`	diff	diff %
ydbd size	6 085 507 544 Bytes	6 085 537 456 Bytes	+29.2 KiB	+0.000%
ydbd stripped size	1 520 428 656 Bytes	1 520 435 248 Bytes	+6.4 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

…nts (ydb-platform#9758) (cherry picked from commit 9dffef6) Conflicts: ydb/library/yql/providers/generic/actors/yql_generic_lookup_actor.cpp

…nts (ydb-platform#9758) (cherry picked from commit 9dffef6)

…7892 #10280 (#10341) Co-authored-by: dmasloff <74042473+dmasloff@users.noreply.github.com> Co-authored-by: Hor911 <hor911@ydb.tech>

streamlookup, generic lookup, yt lookup: remove TUVMap usage from events

93881c1

github-actions bot added the not-for-changelog label Sep 25, 2024

yumkam changed the title ~~streamlookup, generic lookup, yt lookup: remove TUVMap usage from events~~ [WIP]/[RFC] streamlookup, generic lookup, yt lookup: remove TUVMap usage from events Sep 25, 2024

github-actions bot added not-for-changelog and removed not-for-changelog labels Sep 25, 2024

yumkam requested a review from vitstn September 25, 2024 14:59

streamlookup/generic actor: replace direct actor usage with events (UB)

65a239f

github-actions bot added not-for-changelog and removed not-for-changelog labels Sep 27, 2024

yumkam changed the title ~~[WIP]/[RFC] streamlookup, generic lookup, yt lookup: remove TUVMap usage from events~~ [RFC] streamlookup, generic lookup, yt lookup: remove TUVMap usage from events Sep 27, 2024

github-actions bot added not-for-changelog and removed not-for-changelog labels Sep 27, 2024

yumkam marked this pull request as ready for review September 30, 2024 10:20

yumkam requested review from a team as code owners September 30, 2024 10:20

yumkam requested review from gridnevvvit, kardymonds, rvu1024, uzhastik and zverevgeny September 30, 2024 10:20

Use event passing in generic lookup test

9328028

uzhastik reviewed Sep 30, 2024

View reviewed changes

ydb/library/yql/dq/actors/input_transforms/dq_input_transform_lookup.cpp Outdated Show resolved Hide resolved

yumkam added 2 commits September 30, 2024 14:31

{generic,yt}_lookup_actor_ut: remove useless std::move

bea453f

Fix style

14aa6c5

yumkam requested a review from uzhastik September 30, 2024 11:38

fix review comments

94b69d5

yumkam changed the title ~~[RFC] streamlookup, generic lookup, yt lookup: remove TUVMap usage from events~~ streamlookup, generic lookup, yt lookup: remove TUVMap usage from events Sep 30, 2024

github-actions bot added not-for-changelog and removed not-for-changelog labels Sep 30, 2024

rvu1024 approved these changes Sep 30, 2024

View reviewed changes

aakulaga-ydb enabled auto-merge (squash) October 1, 2024 11:53

uzhastik approved these changes Oct 1, 2024

View reviewed changes

aakulaga-ydb merged commit 9dffef6 into ydb-platform:main Oct 1, 2024

GrigoriyPA mentioned this pull request Oct 8, 2024

YQ-3722 add simdjson parser into RD #10204

Merged

yumkam added a commit to yumkam/ydb that referenced this pull request Oct 11, 2024

streamlookup, generic lookup, yt lookup: remove TUVMap usage from eve…

bc032ee

…nts (ydb-platform#9758) (cherry picked from commit 9dffef6)

yumkam added a commit that referenced this pull request Oct 18, 2024

Streamlookup stable backports #7782 #9758 #9396 #10283 #10489 #10508 #…

9a9711d

…7892 #10280 (#10341) Co-authored-by: dmasloff <74042473+dmasloff@users.noreply.github.com> Co-authored-by: Hor911 <hor911@ydb.tech>

This was referenced Oct 21, 2024

Fix kafka cdc read and login without @ #10678

Merged

Allow short auto partitioning strategies yql #10701

Merged

GrigoriyPA mentioned this pull request Oct 29, 2024

YQ RD pass UV from parser to filter #11078

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

streamlookup, generic lookup, yt lookup: remove TUVMap usage from events #9758

streamlookup, generic lookup, yt lookup: remove TUVMap usage from events #9758

Uh oh!

yumkam commented Sep 25, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 27, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 27, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 30, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 30, 2024 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 30, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 30, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 30, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

streamlookup, generic lookup, yt lookup: remove TUVMap usage from events #9758

streamlookup, generic lookup, yt lookup: remove TUVMap usage from events #9758

Uh oh!

Conversation

yumkam commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog entry

Changelog category

Additional information

Uh oh!

github-actions bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yumkam commented Sep 25, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024 •

edited

Loading

github-actions bot commented Sep 27, 2024 •

edited

Loading

github-actions bot commented Sep 27, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading