Skip to content

Conversation

@dmasloff
Copy link
Contributor

Changelog entry

We are planning to set SpacesInLineCommentPrefix=1 in the default clang-format config

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Codestyle fix

@dmasloff dmasloff requested a review from a team as a code owner August 14, 2024 12:39
@github-actions
Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@vitalyisaev2 vitalyisaev2 added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Aug 14, 2024
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Aug 14, 2024
@github-actions
Copy link

github-actions bot commented Aug 14, 2024

2024-08-14 13:40:37 UTC Pre-commit check for c5d8022 has started.
2024-08-14 13:45:04 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-14 15:45:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38469 33109 0 4 5319 37

2024-08-14 15:49:58 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-14 15:59:21 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 34 0 0 0 30

🟢 2024-08-14 15:59:30 UTC Build successful.
🟢 2024-08-14 16:00:14 UTC ydbd size 8.1 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 215cfaa merge: c5d8022 diff diff %
ydbd size 8 725 279 992 Bytes 8 725 279 960 Bytes -32 Bytes -0.000%
ydbd stripped size 474 250 120 Bytes 474 250 120 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 14, 2024

2024-08-14 13:40:43 UTC Pre-commit check for c5d8022 has started.
2024-08-14 13:43:41 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-14 13:49:30 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 14, 2024

2024-08-14 13:40:46 UTC Pre-commit check for c5d8022 has started.
2024-08-14 13:43:34 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-14 15:55:31 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9816 9749 0 10 23 34

🟢 2024-08-14 15:56:44 UTC Build successful.
🟢 2024-08-14 15:57:12 UTC ydbd size 5.5 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 215cfaa merge: c5d8022 diff diff %
ydbd size 5 869 876 232 Bytes 5 869 876 136 Bytes -96 Bytes -0.000%
ydbd stripped size 1 473 512 848 Bytes 1 473 512 784 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ionagamed
Copy link
Contributor

@uzhastik hey! Can we merge this? asan tests probably have nothing to do with moving spaces around in comments :)

@maximyurchuk maximyurchuk merged commit 1f7017f into ydb-platform:main Aug 15, 2024
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
yumkam pushed a commit to yumkam/ydb that referenced this pull request Oct 11, 2024
yumkam added a commit that referenced this pull request Oct 18, 2024
…7892 #10280 (#10341)

Co-authored-by: dmasloff <74042473+dmasloff@users.noreply.github.com>
Co-authored-by: Hor911 <hor911@ydb.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants