sprintf -> snprintf replacement inside ydb code #952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 3287e47.
🔴 linux-x86_64-release-asan: some tests FAILED for commit 3287e47.
|
adameat
reviewed
Jan 12, 2024
| @@ -18,7 +18,7 @@ TString TLogoBlobID::ToString() const { | |||
|
|
|||
| void TLogoBlobID::Out(IOutputStream &o) const { | |||
| char buf[240]; | |||
| sprintf(buf, | |||
| snprintf(buf, sizeof(buf), | |||
There was a problem hiding this comment.
I suggest you to rewrite it like this:
o << '[' << TabletID() << ':' << Generation() << ':' ....
There was a problem hiding this comment.
считаю, что это другая задача, которую нужно делать в другом PR
va-kuznecov
approved these changes
Jan 12, 2024
| @@ -18,7 +18,7 @@ TString TLogoBlobID::ToString() const { | |||
|
|
|||
| void TLogoBlobID::Out(IOutputStream &o) const { | |||
| char buf[240]; | |||
| sprintf(buf, | |||
| snprintf(buf, sizeof(buf), | |||
There was a problem hiding this comment.
считаю, что это другая задача, которую нужно делать в другом PR
This was referenced Jan 15, 2024
Closed
Closed
Merged
Merged
This was referenced Jan 25, 2024
Merged
Merged
This was referenced Jan 29, 2024
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 6, 2024
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Feb 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st step to fix MacOS build