Skip to content

little optimizations for healthcheck #9221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

adameat
Copy link
Member

@adameat adameat commented Sep 13, 2024

Changelog entry

little optimizations for healthcheck

Changelog category

  • Performance improvement
  • Not for changelog (changelog entry is not required)

@adameat adameat requested a review from a team as a code owner September 13, 2024 12:14
@adameat adameat requested a review from vporyadke September 13, 2024 12:14
Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 12:17:21 UTC Pre-commit check linux-x86_64-release-asan for 25640c8 has started.
2024-09-13 12:18:03 UTC Artifacts will be uploaded here
2024-09-13 12:21:40 UTC ya make is running...
🔴 2024-09-13 12:24:52 UTC Build failed, see the logs.

Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 12:19:05 UTC Pre-commit check linux-x86_64-release-clang14 for 25640c8 has started.
2024-09-13 12:19:15 UTC Artifacts will be uploaded here
2024-09-13 12:22:06 UTC ya make is running...
🔴 2024-09-13 12:25:11 UTC Build failed, see the logs.

Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 12:21:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 25640c8 has started.
2024-09-13 12:22:26 UTC Artifacts will be uploaded here
2024-09-13 12:25:27 UTC ya make is running...
🔴 2024-09-13 12:29:59 UTC Build failed, see the logs.

vporyadke
vporyadke previously approved these changes Sep 13, 2024
@adameat adameat requested review from vporyadke and removed request for a team September 16, 2024 04:38
Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 04:40:22 UTC Pre-commit check linux-x86_64-release-clang14 for 7c597bb has started.
2024-09-16 04:40:32 UTC Artifacts will be uploaded here
2024-09-16 04:43:20 UTC ya make is running...
🟢 2024-09-16 04:49:02 UTC Build successful.

Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 04:40:49 UTC Pre-commit check linux-x86_64-release-asan for 7c597bb has started.
2024-09-16 04:40:59 UTC Artifacts will be uploaded here
2024-09-16 04:43:46 UTC ya make is running...
🔴 2024-09-16 06:20:47 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10410 10243 0 28 38 101

🟢 2024-09-16 06:21:41 UTC Build successful.
🟢 2024-09-16 06:22:14 UTC ydbd size 5.6 GiB changed* by -136.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2ed4fb0 merge: 7c597bb diff diff %
ydbd size 6 052 087 688 Bytes 6 051 947 768 Bytes -136.6 KiB -0.002%
ydbd stripped size 1 514 739 504 Bytes 1 514 721 648 Bytes -17.4 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 04:40:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7c597bb has started.
2024-09-16 04:41:04 UTC Artifacts will be uploaded here
2024-09-16 04:43:59 UTC ya make is running...
🟡 2024-09-16 05:45:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15032 13397 0 4 1366 265

🟢 2024-09-16 05:47:56 UTC ydbd size 8.4 GiB changed* by -200.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2ed4fb0 merge: 7c597bb diff diff %
ydbd size 9 042 343 672 Bytes 9 042 138 128 Bytes -200.7 KiB -0.002%
ydbd stripped size 488 897 160 Bytes 488 888 584 Bytes -8.4 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat enabled auto-merge (squash) September 16, 2024 05:42
vporyadke
vporyadke previously approved these changes Sep 16, 2024
Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 08:39:29 UTC Pre-commit check linux-x86_64-release-clang14 for b94f079 has started.
2024-09-17 08:39:36 UTC Artifacts will be uploaded here
2024-09-17 08:42:21 UTC ya make is running...
🟢 2024-09-17 08:49:05 UTC Build successful.

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 08:40:02 UTC Pre-commit check linux-x86_64-release-asan for b94f079 has started.
2024-09-17 08:40:46 UTC Artifacts will be uploaded here
2024-09-17 08:44:16 UTC ya make is running...
🔴 2024-09-17 10:32:00 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10418 10055 0 38 46 279

🟢 2024-09-17 10:33:26 UTC ydbd size 5.6 GiB changed* by -129.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: e8c3843 merge: b94f079 diff diff %
ydbd size 6 045 182 944 Bytes 6 045 050 544 Bytes -129.3 KiB -0.002%
ydbd stripped size 1 513 004 272 Bytes 1 512 994 416 Bytes -9.6 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-09-17 10:33:28 UTC Check cancelled

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 08:40:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for b94f079 has started.
2024-09-17 08:40:35 UTC Artifacts will be uploaded here
2024-09-17 08:43:21 UTC ya make is running...
🟡 2024-09-17 09:47:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15051 13569 0 3 1377 102

2024-09-17 09:48:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-17 09:55:50 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
111 (only retried tests) 21 0 0 0 90

🟢 2024-09-17 09:55:57 UTC Build successful.
🟢 2024-09-17 09:56:54 UTC ydbd size 8.4 GiB changed* by -201.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: e8c3843 merge: b94f079 diff diff %
ydbd size 9 030 321 240 Bytes 9 030 115 032 Bytes -201.4 KiB -0.002%
ydbd stripped size 488 727 624 Bytes 488 719 048 Bytes -8.4 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 10:37:16 UTC Pre-commit check linux-x86_64-release-clang14 for dc1b67a has started.
2024-09-17 10:37:43 UTC Artifacts will be uploaded here
2024-09-17 10:40:32 UTC ya make is running...
🟢 2024-09-17 10:46:38 UTC Build successful.

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 10:37:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for dc1b67a has started.
2024-09-17 10:37:39 UTC Artifacts will be uploaded here
2024-09-17 10:40:31 UTC ya make is running...
🟡 2024-09-17 11:45:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15057 13591 0 3 1372 91

2024-09-17 11:46:48 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-17 11:54:01 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
96 (only retried tests) 10 0 0 0 86

🟢 2024-09-17 11:54:07 UTC Build successful.
🟢 2024-09-17 11:54:48 UTC ydbd size 8.4 GiB changed* by -201.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4cd7f0a merge: dc1b67a diff diff %
ydbd size 9 030 406 616 Bytes 9 030 200 816 Bytes -201.0 KiB -0.002%
ydbd stripped size 488 733 032 Bytes 488 724 456 Bytes -8.4 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 10:37:29 UTC Pre-commit check linux-x86_64-release-asan for dc1b67a has started.
2024-09-17 10:37:40 UTC Artifacts will be uploaded here
2024-09-17 10:40:40 UTC ya make is running...
🔴 2024-09-17 12:35:53 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10429 10049 0 43 66 271

🟢 2024-09-17 12:36:48 UTC Build successful.
🟢 2024-09-17 12:37:23 UTC ydbd size 5.6 GiB changed* by -132.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4cd7f0a merge: dc1b67a diff diff %
ydbd size 6 045 289 152 Bytes 6 045 153 024 Bytes -132.9 KiB -0.002%
ydbd stripped size 1 513 040 112 Bytes 1 513 026 224 Bytes -13.6 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat merged commit bdedefb into ydb-platform:main Sep 17, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants