return up-to-date node stats KIKIMR-20697 #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 5ea5e84.
🔴 linux-x86_64-release-asan: some tests FAILED for commit 5ea5e84.
|
adameat
reviewed
Jan 10, 2024
ydb/core/mind/hive/hive_impl.cpp
Outdated
| @@ -1780,7 +1780,7 @@ bool THive::IsTabletMoveExpedient(const TTabletInfo& tablet, const TNodeInfo& no | |||
| return result; | |||
| } | |||
|
|
|||
| void THive::FillTabletInfo(NKikimrHive::TEvResponseHiveInfo& response, ui64 tabletId, const TLeaderTabletInfo *info, const NKikimrHive::TEvRequestHiveInfo &req) { | |||
| void THive::FillTabletInfo(NKikimrHive::TEvResponseHiveInfo& response, ui64 tabletId, const TLeaderTabletInfo *info, const NKikimrHive::TEvRequestHiveInfo &req, TInstant restartsBarrierTime) { | |||
There was a problem hiding this comment.
is it possible to put the barrier argument deeper down? TActivationContext::Now() is relatively a cheap call.
There was a problem hiding this comment.
FillTabletInfo is a static member function and as such it does not have access to TabletRestartPeriod from config
There was a problem hiding this comment.
it doesn't have to be static forever
adameat
approved these changes
Jan 10, 2024
Merged
This was referenced Jan 15, 2024
Closed
Closed
Merged
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 6, 2024
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Feb 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.