Skip to content

Conversation

@lll-phill-lll
Copy link
Member

@lll-phill-lll lll-phill-lll commented Sep 5, 2024

Changelog entry

Split wideCombiner's state into buckets earlier - when the memory limit is set. It should prevent OOM after hash table x2 growth
...

Changelog category

  • Improvement

Additional information

...

@lll-phill-lll lll-phill-lll requested a review from a team as a code owner September 5, 2024 13:13
@github-actions
Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 14:34:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3d9b6f0 has started.
2024-09-05 14:37:45 UTC ya make is running...
🟡 2024-09-05 16:36:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
78501 64719 0 7 13749 26

2024-09-05 16:44:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-05 16:52:00 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
42 (only retried tests) 23 0 0 1 18

🟢 2024-09-05 16:52:08 UTC Build successful.
🟢 2024-09-05 16:52:43 UTC ydbd size 8.4 GiB changed* by +920 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 90dd99a merge: 3d9b6f0 diff diff %
ydbd size 8 999 780 888 Bytes 8 999 781 808 Bytes +920 Bytes +0.000%
ydbd stripped size 486 649 224 Bytes 486 649 224 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 14:35:29 UTC Pre-commit check linux-x86_64-release-clang14 for 3d9b6f0 has started.
2024-09-05 14:39:06 UTC ya make is running...
🟢 2024-09-05 15:49:18 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 14:45:26 UTC Pre-commit check linux-x86_64-release-asan for 3d9b6f0 has started.
2024-09-05 14:48:44 UTC ya make is running...
🔴 2024-09-05 17:21:10 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16277 16151 0 47 45 34

🟢 2024-09-05 17:22:43 UTC Build successful.
🟢 2024-09-05 17:23:18 UTC ydbd size 5.6 GiB changed* by +464 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 90dd99a merge: 3d9b6f0 diff diff %
ydbd size 6 017 807 040 Bytes 6 017 807 504 Bytes +464 Bytes +0.000%
ydbd stripped size 1 507 089 200 Bytes 1 507 089 136 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lll-phill-lll lll-phill-lll changed the title Grow wide combiner state less round 3 Split WideCombiners state into buckets earlier Sep 9, 2024
@github-actions
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 16:37:13 UTC Pre-commit check linux-x86_64-release-clang14 for b9df9fd has started.
2024-09-09 16:40:23 UTC ya make is running...
🟢 2024-09-09 17:17:47 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 16:42:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for b9df9fd has started.
2024-09-09 16:46:36 UTC ya make is running...
🟡 2024-09-09 18:30:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
78553 64753 0 3 13776 21

2024-09-09 18:38:44 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-09 18:45:52 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
34 (only retried tests) 16 0 0 1 17

🟢 2024-09-09 18:45:59 UTC Build successful.
🟢 2024-09-09 18:46:37 UTC ydbd size 8.4 GiB changed* by +1008 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: d22f086 merge: b9df9fd diff diff %
ydbd size 9 023 440 064 Bytes 9 023 441 072 Bytes +1008 Bytes +0.000%
ydbd stripped size 487 701 480 Bytes 487 701 480 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 16:47:18 UTC Pre-commit check linux-x86_64-release-asan for b9df9fd has started.
2024-09-09 16:50:35 UTC ya make is running...
🔴 2024-09-09 19:07:08 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16305 16187 0 46 41 31

🟢 2024-09-09 19:08:35 UTC Build successful.
🟢 2024-09-09 19:09:08 UTC ydbd size 5.6 GiB changed* by +4.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d22f086 merge: b9df9fd diff diff %
ydbd size 6 036 482 440 Bytes 6 036 487 288 Bytes +4.7 KiB +0.000%
ydbd stripped size 1 511 083 248 Bytes 1 511 087 472 Bytes +4.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants