Skip to content

Conversation

@lll-phill-lll
Copy link
Member

@lll-phill-lll lll-phill-lll commented Nov 22, 2024

Changelog entry

Added missing spilling-related commits. Spilling is expected to become enabled in 24-4, so spilling-related code must be correct in 24-3. Reasons are described in #11885.

PRs of added commits:
#9785
#8939
#8804
#10997
...

Changelog category

  • Bugfix

Additional information

...

@lll-phill-lll lll-phill-lll requested a review from a team as a code owner November 22, 2024 13:37
@github-actions
Copy link

github-actions bot commented Nov 22, 2024

2024-11-22 13:39:31 UTC Pre-commit check for 4ca5dea has started.
2024-11-22 13:42:30 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-22 14:17:37 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 22, 2024

2024-11-22 13:41:32 UTC Pre-commit check for 4ca5dea has started.
2024-11-22 13:44:31 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-22 14:29:05 UTC Build successful.
2024-11-22 14:29:21 UTC Tests are running...
🔴 2024-11-22 16:44:33 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15749 15593 0 61 53 42

🟢 2024-11-22 16:45:19 UTC ydbd size 5.6 GiB changed* by +47.3 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 0ab8d25 merge: 4ca5dea diff diff %
ydbd size 5 996 910 576 Bytes 5 996 959 048 Bytes +47.3 KiB +0.001%
ydbd stripped size 1 503 010 976 Bytes 1 503 030 240 Bytes +18.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 22, 2024

2024-11-22 13:42:12 UTC Pre-commit check for 4ca5dea has started.
2024-11-22 13:45:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-22 14:44:28 UTC Build successful.
2024-11-22 14:44:44 UTC Tests are running...
🔴 2024-11-22 16:59:05 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76865 63358 0 33 13434 40

🟢 2024-11-22 16:59:54 UTC ydbd size 8.3 GiB changed* by +47.8 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 0ab8d25 merge: 4ca5dea diff diff %
ydbd size 8 865 263 456 Bytes 8 865 312 360 Bytes +47.8 KiB +0.001%
ydbd stripped size 484 011 848 Bytes 484 021 032 Bytes +9.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lll-phill-lll lll-phill-lll changed the title Stable 24 3 Add missing spilling commits Nov 22, 2024
@lll-phill-lll
Copy link
Member Author

Compared failed tests with the previous commit. #11866
The diff and description is here: https://nda.ya.ru/t/tVbeTaEX79qvrv
Also attaching this diff as screenshot:
Screenshot 2024-11-22 at 19 11 33

Resolution: can be merged

@lll-phill-lll lll-phill-lll merged commit 9d525db into ydb-platform:stable-24-3 Nov 22, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants