Skip to content

[Ldap] Remove redundant details from error message. Add logging to ldap auth provider #7060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2024
Merged

[Ldap] Remove redundant details from error message. Add logging to ldap auth provider #7060

merged 2 commits into from
Jul 25, 2024

Conversation

@molotkov-and
Copy link
Collaborator

@molotkov-and molotkov-and commented Jul 24, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

@molotkov-and molotkov-and marked this pull request as draft July 24, 2024 18:04
@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 18:06:32 UTC Pre-commit check for f7e706a has started.
⚪ 2024-07-24 18:09:47 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-24 18:50:17 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 18:07:08 UTC Pre-commit check for f7e706a has started.
⚪ 2024-07-24 18:10:12 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 20:54:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75020 61461 0 1 13547 11

⚪ 2024-07-24 21:04:52 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 21:12:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11 (only retried tests) 2 0 1 0 8

⚪ 2024-07-24 21:23:28 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 21:31:03 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10 (only retried tests) 1 0 1 0 8

🟢 2024-07-24 21:38:31 UTC Build successful.
🟢 2024-07-24 21:39:17 UTC ydbd size 8.1 GiB changed* by +64.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: babf6c1 merge: f7e706a diff diff %
ydbd size 8 659 058 728 Bytes 8 659 125 072 Bytes +64.8 KiB +0.001%
ydbd stripped size 471 301 248 Bytes 471 306 432 Bytes +5.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 18:12:39 UTC Pre-commit check for f7e706a has started.
⚪ 2024-07-24 18:15:56 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-24 20:47:51 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13569 12966 0 97 330 176

🟢 2024-07-24 20:49:43 UTC Build successful.
🟢 2024-07-24 20:50:34 UTC ydbd size 5.2 GiB changed* by -57.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: babf6c1 merge: f7e706a diff diff %
ydbd size 5 559 630 504 Bytes 5 559 572 080 Bytes -57.1 KiB -0.001%
ydbd stripped size 1 197 553 680 Bytes 1 197 553 616 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and force-pushed the ldap/remove-detailed-error branch from 9868016 to 8ba2174 Compare July 25, 2024 07:17
@molotkov-and molotkov-and marked this pull request as ready for review July 25, 2024 07:18
@github-actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 07:19:48 UTC Pre-commit check for 3c87975 has started.
⚪ 2024-07-25 07:23:01 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-25 08:07:50 UTC Build successful.

@molotkov-and molotkov-and changed the title Ldap/remove detailed error [Ldap] Remove redundant details from error message. Add logging to ldap auth provider Jul 25, 2024
@github-actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 07:20:21 UTC Pre-commit check for 3c87975 has started.
⚪ 2024-07-25 07:23:24 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-25 10:06:15 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13569 12969 0 86 336 178

🟢 2024-07-25 10:07:32 UTC Build successful.
🟢 2024-07-25 10:08:24 UTC ydbd size 5.2 GiB changed* by +31.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0475ae0 merge: 3c87975 diff diff %
ydbd size 5 559 787 936 Bytes 5 559 820 272 Bytes +31.6 KiB +0.001%
ydbd stripped size 1 197 590 448 Bytes 1 197 601 456 Bytes +10.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and requested a review from adameat July 25, 2024 07:20
@github-actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 07:21:50 UTC Pre-commit check for 3c87975 has started.
⚪ 2024-07-25 07:25:10 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-25 10:08:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75025 61458 0 2 13549 16

⚪ 2024-07-25 10:16:29 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-25 10:24:57 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 8 0 0 0 10

🟢 2024-07-25 10:31:57 UTC Build successful.
🟢 2024-07-25 10:32:48 UTC ydbd size 8.1 GiB changed* by +78.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0475ae0 merge: 3c87975 diff diff %
ydbd size 8 659 253 768 Bytes 8 659 334 096 Bytes +78.4 KiB +0.001%
ydbd stripped size 471 309 088 Bytes 471 315 680 Bytes +6.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and merged commit af4bb4b into ydb-platform:main Jul 25, 2024
@molotkov-and molotkov-and deleted the ldap/remove-detailed-error branch July 25, 2024 11:01
molotkov-and added a commit to molotkov-and/ydb that referenced this pull request Jul 26, 2024
@molotkov-and
[Ldap] Remove redundant details from error message. Add logging to ld…
d8dc1ac 
…ap auth provider (ydb-platform#7060)
This was referenced Nov 12, 2024
Merged
Merged
ijon added a commit that referenced this pull request Nov 13, 2024
@ijon
24-3: auditlog: fix logging for unsuccessful ldap logins (#11492)
063dc25 
merge af4bb4b(#7060), f73f6dc(#11403), 3d0d6db(#11404), 790417d(#11438) from `main`.

Co-authored-by: Andrey Molotkov <molotkov-and@ydb.tech>

Move audit logging of login operations from schemeshard to grpc service auth (`AuthService`).
Update web-login service login to utilize `AuthService.Login`.
Establish `AuthService` as the sole gateway and audit point for all login operations.

### Changelog entry

Fix audit log not recording unsuccessful ldap logins.

### Changelog category

* Bugfix
zinal pushed a commit to zinal/ydb that referenced this pull request Nov 13, 2024
@ijon @zinal
24-3: auditlog: fix logging for unsuccessful ldap logins (ydb-platfor…
0feca15 
…m#11492)

merge af4bb4b(ydb-platform#7060), f73f6dc(ydb-platform#11403), 3d0d6db(ydb-platform#11404), 790417d(ydb-platform#11438) from `main`.

Co-authored-by: Andrey Molotkov <molotkov-and@ydb.tech>

Move audit logging of login operations from schemeshard to grpc service auth (`AuthService`).
Update web-login service login to utilize `AuthService.Login`.
Establish `AuthService` as the sole gateway and audit point for all login operations.

### Changelog entry

Fix audit log not recording unsuccessful ldap logins.

### Changelog category

* Bugfix
zinal pushed a commit to zinal/ydb that referenced this pull request Nov 20, 2024
@ijon @zinal
24-3: auditlog: fix logging for unsuccessful ldap logins (ydb-platfor…
f5a10a8 
…m#11492)

merge af4bb4b(ydb-platform#7060), f73f6dc(ydb-platform#11403), 3d0d6db(ydb-platform#11404), 790417d(ydb-platform#11438) from `main`.

Co-authored-by: Andrey Molotkov <molotkov-and@ydb.tech>

Move audit logging of login operations from schemeshard to grpc service auth (`AuthService`).
Update web-login service login to utilize `AuthService.Login`.
Establish `AuthService` as the sole gateway and audit point for all login operations.

### Changelog entry

Fix audit log not recording unsuccessful ldap logins.

### Changelog category

* Bugfix
zinal pushed a commit to zinal/ydb that referenced this pull request Nov 30, 2024
@ijon @zinal
24-3: auditlog: fix logging for unsuccessful ldap logins (ydb-platfor…
066d9c6 
…m#11492)

merge af4bb4b(ydb-platform#7060), f73f6dc(ydb-platform#11403), 3d0d6db(ydb-platform#11404), 790417d(ydb-platform#11438) from `main`.

Co-authored-by: Andrey Molotkov <molotkov-and@ydb.tech>

Move audit logging of login operations from schemeshard to grpc service auth (`AuthService`).
Update web-login service login to utilize `AuthService.Login`.
Establish `AuthService` as the sole gateway and audit point for all login operations.

### Changelog entry

Fix audit log not recording unsuccessful ldap logins.

### Changelog category

* Bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adameat adameat adameat approved these changes

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@molotkov-and @adameat