Skip to content

Conversation

@ijon
Copy link
Collaborator

@ijon ijon commented Nov 11, 2024

Move audit logging of login operations from schemeshard to grpc service auth (AuthService).
Update web-login service login to utilize AuthService.Login.
Establish AuthService as the sole gateway and audit point for all login operations.

merge af4bb4b(#7060), f73f6dc(#11403), 3d0d6db(#11404), 790417d(#11438) from main.

Changelog entry

Fix audit log not recording unsuccessful ldap logins.

Changelog category

  • Bugfix

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

molotkov-and and others added 4 commits November 12, 2024 13:08
Move audit logging of login operations from schemeshard to grpc service auth (`AuthService`).
Update web-login service login to utilize `AuthService.Login`.
Establish `AuthService` as the sole gateway and single audit point for all login operations.

KIKIMR-22173
@ijon ijon force-pushed the merge/24-3/auditlog-fix-ldap-failed-login branch from ecf893c to f9c53d9 Compare November 12, 2024 10:32
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Nov 12, 2024

2024-11-12 12:04:59 UTC Pre-commit check for 49b15c8 has started.
2024-11-12 12:08:02 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-12 12:40:24 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 12, 2024

2024-11-12 12:05:26 UTC Pre-commit check for 49b15c8 has started.
2024-11-12 12:09:00 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-12 12:56:54 UTC Build successful.
2024-11-12 12:57:08 UTC Tests are running...
🔴 2024-11-12 15:17:23 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14335 14188 0 49 53 45

🟡 2024-11-12 15:18:06 UTC ydbd size 5.6 GiB changed* by +813.0 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: afbd118 merge: 49b15c8 diff diff %
ydbd size 5 991 968 752 Bytes 5 992 801 248 Bytes +813.0 KiB +0.014%
ydbd stripped size 1 501 736 064 Bytes 1 501 856 832 Bytes +117.9 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 12, 2024

2024-11-12 15:23:42 UTC Pre-commit check for 49b15c8 has started.
2024-11-12 15:26:57 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-12 16:09:35 UTC Build successful.
2024-11-12 16:12:12 UTC Tests are running...
🔴 2024-11-12 18:26:07 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75498 62013 0 15 13432 38

🟡 2024-11-12 18:26:58 UTC ydbd size 8.3 GiB changed* by +818.3 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: afbd118 merge: 49b15c8 diff diff %
ydbd size 8 858 816 656 Bytes 8 859 654 632 Bytes +818.3 KiB +0.009%
ydbd stripped size 483 705 224 Bytes 483 740 168 Bytes +34.1 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon marked this pull request as ready for review November 12, 2024 19:37
@ijon ijon requested a review from a team as a code owner November 12, 2024 19:37
@ijon ijon merged commit 063dc25 into ydb-platform:stable-24-3 Nov 13, 2024
8 of 12 checks passed
@ijon ijon deleted the merge/24-3/auditlog-fix-ldap-failed-login branch November 13, 2024 09:27
zinal pushed a commit to zinal/ydb that referenced this pull request Nov 13, 2024
…m#11492)

merge af4bb4b(ydb-platform#7060), f73f6dc(ydb-platform#11403), 3d0d6db(ydb-platform#11404), 790417d(ydb-platform#11438) from `main`.

Co-authored-by: Andrey Molotkov <molotkov-and@ydb.tech>

Move audit logging of login operations from schemeshard to grpc service auth (`AuthService`).
Update web-login service login to utilize `AuthService.Login`.
Establish `AuthService` as the sole gateway and audit point for all login operations.

### Changelog entry

Fix audit log not recording unsuccessful ldap logins.

### Changelog category

* Bugfix
zinal pushed a commit to zinal/ydb that referenced this pull request Nov 20, 2024
…m#11492)

merge af4bb4b(ydb-platform#7060), f73f6dc(ydb-platform#11403), 3d0d6db(ydb-platform#11404), 790417d(ydb-platform#11438) from `main`.

Co-authored-by: Andrey Molotkov <molotkov-and@ydb.tech>

Move audit logging of login operations from schemeshard to grpc service auth (`AuthService`).
Update web-login service login to utilize `AuthService.Login`.
Establish `AuthService` as the sole gateway and audit point for all login operations.

### Changelog entry

Fix audit log not recording unsuccessful ldap logins.

### Changelog category

* Bugfix
zinal pushed a commit to zinal/ydb that referenced this pull request Nov 30, 2024
…m#11492)

merge af4bb4b(ydb-platform#7060), f73f6dc(ydb-platform#11403), 3d0d6db(ydb-platform#11404), 790417d(ydb-platform#11438) from `main`.

Co-authored-by: Andrey Molotkov <molotkov-and@ydb.tech>

Move audit logging of login operations from schemeshard to grpc service auth (`AuthService`).
Update web-login service login to utilize `AuthService.Login`.
Establish `AuthService` as the sole gateway and audit point for all login operations.

### Changelog entry

Fix audit log not recording unsuccessful ldap logins.

### Changelog category

* Bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants