Skip to content

Don't store zero priority in proto #5753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

pixcc
Copy link
Member

@pixcc pixcc commented Jun 19, 2024

Changelog category

  • Not for changelog (changelog entry is not required)

CyberROFL
CyberROFL previously approved these changes Jun 19, 2024
CyberROFL
CyberROFL previously approved these changes Jun 19, 2024
Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 17:23:32 UTC Pre-commit check for eb34a90 has started.
2024-06-19 17:25:59 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-19 17:27:38 UTC Build successful.
2024-06-19 17:27:46 UTC Tests are running...
🔴 2024-06-19 19:09:48 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9490 9387 0 72 24 7

🟢 2024-06-19 19:10:24 UTC merge: eb34a90 ydbd size 5.7 GiB +64 Bytes +0.000% vs build main: 1a63699

Build size details

main: 1a63699 ydbd build size:

  • binary size 6 148 811 400 Bytes
  • stripped binary size 1 527 388 480 Bytes

merge: eb34a90 ydbd build size:

  • binary size 6 148 811 464 Bytes
  • stripped binary size 1 527 388 672 Bytes

ydbd size dashboard

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 17:37:57 UTC Pre-commit check for eb34a90 has started.
2024-06-19 17:40:27 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-19 17:42:01 UTC Build successful.

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 17:54:08 UTC Pre-commit check for eb34a90 has started.
2024-06-19 17:56:30 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-19 17:58:05 UTC Build successful.
2024-06-19 17:58:18 UTC Tests are running...
🔴 2024-06-19 19:22:44 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13604 12261 0 59 1274 10

🟢 2024-06-19 19:23:23 UTC merge: eb34a90 ydbd size 8.6 GiB +392 Bytes +0.000% vs build main: 1a63699

Build size details

main: 1a63699 ydbd build size:

  • binary size 9 214 091 880 Bytes
  • stripped binary size 711 255 088 Bytes

merge: eb34a90 ydbd build size:

  • binary size 9 214 092 272 Bytes
  • stripped binary size 711 255 088 Bytes

ydbd size dashboard

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 20:16:45 UTC Pre-commit check for 7cdb51d has started.
2024-06-19 20:19:15 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-19 20:21:52 UTC Build successful.

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 20:16:47 UTC Pre-commit check for 7cdb51d has started.
2024-06-19 20:19:13 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-19 20:21:07 UTC Build successful.
2024-06-19 20:21:19 UTC Tests are running...
🔴 2024-06-19 21:37:06 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13588 12298 0 2 1275 13

🟢 2024-06-19 21:37:46 UTC merge: 7cdb51d ydbd size 8.6 GiB +456 Bytes +0.000% vs build main: 62869e9

Build size details

main: 62869e9 ydbd build size:

  • binary size 9 214 092 544 Bytes
  • stripped binary size 711 254 960 Bytes

merge: 7cdb51d ydbd build size:

  • binary size 9 214 093 000 Bytes
  • stripped binary size 711 255 024 Bytes

ydbd size dashboard

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 20:16:50 UTC Pre-commit check for 7cdb51d has started.
2024-06-19 20:19:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-19 20:21:32 UTC Build successful.
2024-06-19 20:21:45 UTC Tests are running...
🔴 2024-06-19 22:09:25 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9495 9430 0 29 26 10

🟢 2024-06-19 22:10:24 UTC merge: 7cdb51d ydbd size 5.7 GiB +128 Bytes +0.000% vs build main: 62869e9

Build size details

main: 62869e9 ydbd build size:

  • binary size 6 148 811 720 Bytes
  • stripped binary size 1 527 389 568 Bytes

merge: 7cdb51d ydbd build size:

  • binary size 6 148 811 848 Bytes
  • stripped binary size 1 527 389 824 Bytes

ydbd size dashboard

@pixcc pixcc merged commit fa1c5d2 into ydb-platform:main Jun 19, 2024
8 of 12 checks passed
pixcc added a commit to pixcc/ydb that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants