Skip to content

oidc-proxy new iam 2 #6059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 18, 2024
Merged

oidc-proxy new iam 2 #6059

merged 24 commits into from
Jul 18, 2024

Conversation

StekPerepolnen
Copy link
Collaborator

@StekPerepolnen StekPerepolnen commented Jun 28, 2024 •
edited
Loading

Changelog entry

issue

  • Added oidc-proxy configuration parameters. This includes auth-profile, which determines the logic that oidc_proxy will follow. Possible options: y-profile, n-profile. Default is y-profile
  • For oidc_proxy handlers, added a new version of logic depending on auth-profile. The old handlers were not changed, so some logic is duplicated. I plan to combine some of the logic in a minor refactoring later.
  • For tokenator (mvp authentithication) added a new version of logic depending on auth-profile also. I plan to new version support for meta later.
  • Moved new iam spec to github into public api
  • Changed the endpoint names in tests to more neutral ones.

Changelog category

  • Improvement
  • Feature

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

⚪ 2024-06-28 09:01:18 UTC Pre-commit check for 6f3d4f5 has started.
⚪ 2024-06-28 09:03:26 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-28 09:04:30 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

⚪ 2024-06-28 09:08:22 UTC Pre-commit check for 6f3d4f5 has started.
⚪ 2024-06-28 09:10:25 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-28 09:11:19 UTC Build successful.
⚪ 2024-06-28 09:11:34 UTC Tests are running...
🟢 2024-06-28 09:11:49 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 16 0 0 0 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

⚪ 2024-06-28 09:16:04 UTC Pre-commit check for 6f3d4f5 has started.
⚪ 2024-06-28 09:18:42 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-28 09:19:28 UTC Build successful.
⚪ 2024-06-28 09:19:38 UTC Tests are running...
🟢 2024-06-28 09:19:52 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 16 0 0 0 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

⚪ 2024-06-28 11:15:08 UTC Pre-commit check for 637bd34 has started.
⚪ 2024-06-28 11:17:51 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-28 11:18:35 UTC Build successful.
⚪ 2024-06-28 11:18:48 UTC Tests are running...
🟢 2024-06-28 11:19:01 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 16 0 0 0 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

⚪ 2024-06-28 11:22:51 UTC Pre-commit check for 637bd34 has started.
⚪ 2024-06-28 11:25:31 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-28 11:26:18 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

⚪ 2024-06-28 11:23:52 UTC Pre-commit check for 637bd34 has started.
⚪ 2024-06-28 11:26:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-28 11:26:55 UTC Build successful.
⚪ 2024-06-28 11:27:05 UTC Tests are running...
🟢 2024-06-28 11:27:18 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 16 0 0 0 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

⚪ 2024-07-01 20:27:05 UTC Pre-commit check for 01350bd has started.
⚪ 2024-07-01 20:29:10 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-01 20:30:01 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

⚪ 2024-07-01 20:31:13 UTC Pre-commit check for 01350bd has started.
⚪ 2024-07-01 20:33:17 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-01 20:34:01 UTC Build successful.
⚪ 2024-07-01 20:34:14 UTC Tests are running...
🟢 2024-07-01 20:34:29 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 16 0 0 0 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

⚪ 2024-07-01 20:35:12 UTC Pre-commit check for 01350bd has started.
⚪ 2024-07-01 20:37:48 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-01 20:38:34 UTC Build successful.
⚪ 2024-07-01 20:38:41 UTC Tests are running...
🟢 2024-07-01 20:38:54 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 16 0 0 0 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

⚪ 2024-07-02 14:37:43 UTC Pre-commit check for a728cc6 has started.
⚪ 2024-07-02 14:39:48 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-02 14:40:28 UTC Build successful.
⚪ 2024-07-02 14:40:35 UTC Tests are running...
🟢 2024-07-02 14:40:48 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 16 0 0 0 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

⚪ 2024-07-02 14:43:06 UTC Pre-commit check for a728cc6 has started.
⚪ 2024-07-02 14:45:07 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-02 14:45:47 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

⚪ 2024-07-02 14:46:50 UTC Pre-commit check for a728cc6 has started.
⚪ 2024-07-02 14:48:51 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-02 14:49:29 UTC Build successful.
⚪ 2024-07-02 14:49:39 UTC Tests are running...
🟢 2024-07-02 14:49:53 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 16 0 0 0 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 21:32:34 UTC Pre-commit check for cf97be5 has started.
⚪ 2024-07-04 21:34:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-04 21:35:22 UTC Build successful.
⚪ 2024-07-04 21:35:37 UTC Tests are running...
🔴 2024-07-04 21:36:51 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17 2 0 4 11 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 21:32:34 UTC Pre-commit check for cf97be5 has started.
⚪ 2024-07-04 21:34:40 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-04 21:35:31 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 21:32:35 UTC Pre-commit check for cf97be5 has started.
⚪ 2024-07-04 21:34:38 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-04 21:35:32 UTC Build successful.
⚪ 2024-07-04 21:35:43 UTC Tests are running...
🔴 2024-07-04 21:36:59 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17 2 0 4 11 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

⚪ 2024-07-04 22:02:03 UTC Pre-commit check for 4f43c3a has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 22:03:22 UTC Pre-commit check for 4f43c3a has started.
⚪ 2024-07-04 22:05:22 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-04 22:06:11 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 22:04:48 UTC Pre-commit check for 4f43c3a has started.
⚫ 2024-07-04 22:06:23 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 22:07:48 UTC Pre-commit check for ba12333 has started.
⚫ 2024-07-04 22:08:17 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 22:09:45 UTC Pre-commit check for 62d801d has started.
⚪ 2024-07-04 22:11:45 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-04 22:12:30 UTC Build successful.

UgnineSirdis
UgnineSirdis reviewed Jul 18, 2024
View reviewed changes
ydb/mvp/oidc_proxy/oidc_session_create_nebius.h

void RemoveAppliedCookie(const TString& cookieName) override {
ResponseHeaders.Set("Set-Cookie", TStringBuilder() << cookieName << "=; Path=" << GetAuthCallbackUrl() << "; Max-Age=0");
ResponseHeaders.Set("Set-Cookie", TStringBuilder() << CreateNameSessionCookie(Settings.ClientId) << "=; Max-Age=0");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it valid to set two headers with the same name?
We have TMap for headers here, not multimap((

UgnineSirdis
UgnineSirdis requested changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@UgnineSirdis UgnineSirdis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comments

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚪ 2024-07-18 13:55:49 UTC Pre-commit check for 2a0ad96 has started.
⚫ 2024-07-18 13:56:56 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚪ 2024-07-18 13:59:06 UTC Pre-commit check for 29d6284 has started.
⚪ 2024-07-18 14:01:15 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-18 14:02:27 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚪ 2024-07-18 13:59:42 UTC Pre-commit check for 29d6284 has started.
⚪ 2024-07-18 14:01:54 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-18 14:03:46 UTC Build successful.
🔴 2024-07-18 14:03:54 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25 9 0 4 12 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚪ 2024-07-18 14:00:57 UTC Pre-commit check for 29d6284 has started.
⚪ 2024-07-18 14:03:18 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-18 14:05:31 UTC Build successful.
🔴 2024-07-18 14:05:47 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25 4 0 2 19 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚪ 2024-07-18 14:24:12 UTC Pre-commit check for 455eefe has started.
⚫ 2024-07-18 14:25:32 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚪ 2024-07-18 14:24:47 UTC Pre-commit check for 455eefe has started.
⚫ 2024-07-18 14:25:39 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚪ 2024-07-18 14:25:13 UTC Pre-commit check for 455eefe has started.
⚫ 2024-07-18 14:25:43 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚪ 2024-07-18 14:27:41 UTC Pre-commit check for ae4d1b8 has started.
⚪ 2024-07-18 14:30:04 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-18 14:31:10 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚪ 2024-07-18 14:27:50 UTC Pre-commit check for ae4d1b8 has started.
⚪ 2024-07-18 14:30:07 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-18 14:31:16 UTC Build successful.
🟢 2024-07-18 14:31:33 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24 24 0 0 0 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚪ 2024-07-18 14:28:09 UTC Pre-commit check for ae4d1b8 has started.
⚪ 2024-07-18 14:30:24 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-18 14:31:29 UTC Build successful.
🟢 2024-07-18 14:31:47 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24 24 0 0 0 0

UgnineSirdis
UgnineSirdis approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@UgnineSirdis UgnineSirdis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other comments we decided to fix in background

@StekPerepolnen StekPerepolnen merged commit 31ea815 into ydb-platform:main Jul 18, 2024
12 checks passed
@StekPerepolnen StekPerepolnen deleted the oidc_oauth2 branch July 18, 2024 15:02
This was referenced Jul 19, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UgnineSirdis UgnineSirdis UgnineSirdis approved these changes

Assignees
No one assigned
Labels
improvement new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StekPerepolnen @UgnineSirdis