Skip to content

Add allow unknown fields to CMS #5743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

pixcc
Copy link
Member

@pixcc pixcc commented Jun 19, 2024

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

This change allows CMS to ignore unknown fields when reading them from the local database. Overwriting the data will cause the unknown fields to be lost.

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 16:17:59 UTC Pre-commit check for a35c88b has started.
2024-06-19 16:20:19 UTC Build linux-x86_64-release-clang14 is running...
2024-06-19 16:20:46 UTC Check cancelled

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 16:19:33 UTC Pre-commit check for a35c88b has started.
2024-06-19 16:20:46 UTC Check cancelled

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 16:21:49 UTC Pre-commit check for 66ef05e has started.
2024-06-19 16:24:15 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-19 16:25:45 UTC Build successful.
2024-06-19 16:25:57 UTC Tests are running...
🔴 2024-06-19 16:43:39 UTC Test run completed, no test results found for commit 07cc568. Please check test log.
2024-06-19 16:43:55 UTC Check cancelled

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 16:37:37 UTC Pre-commit check for 66ef05e has started.
2024-06-19 16:39:58 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-19 16:41:31 UTC Build successful.

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 16:39:02 UTC Pre-commit check for 66ef05e has started.
2024-06-19 16:41:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-19 16:42:48 UTC Build successful.
2024-06-19 16:43:01 UTC Tests are running...
🔴 2024-06-19 16:43:29 UTC Test run completed, no test results found for commit 07cc568. Please check test log.
2024-06-19 16:43:35 UTC Check cancelled

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 16:48:05 UTC Pre-commit check for 6674d7b has started.
2024-06-19 16:49:19 UTC Check cancelled

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 16:53:12 UTC Pre-commit check for 7083a1b has started.
2024-06-19 16:55:39 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-19 16:57:22 UTC Build successful.
2024-06-19 16:57:40 UTC Tests are running...
🔴 2024-06-19 18:41:35 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9471 9411 0 19 32 9

🟢 2024-06-19 18:42:13 UTC merge: 7083a1b ydbd size 5.7 GiB +3.0 KiB +0.000% vs build main: 1a63699

Build size details

main: 1a63699 ydbd build size:

  • binary size 6 148 811 400 Bytes
  • stripped binary size 1 527 388 480 Bytes

merge: 7083a1b ydbd build size:

  • binary size 6 148 814 472 Bytes
  • stripped binary size 1 527 389 888 Bytes

ydbd size dashboard

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 16:54:05 UTC Pre-commit check for 7083a1b has started.
2024-06-19 16:56:27 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-19 16:58:00 UTC Build successful.

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 17:35:30 UTC Pre-commit check for 7083a1b has started.
2024-06-19 17:37:52 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-19 17:39:21 UTC Build successful.
2024-06-19 17:39:33 UTC Tests are running...
🔴 2024-06-19 18:52:51 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13584 12292 0 1 1282 9

🟢 2024-06-19 18:53:32 UTC merge: 7083a1b ydbd size 8.6 GiB +4.7 KiB +0.000% vs build main: 1a63699

Build size details

main: 1a63699 ydbd build size:

  • binary size 9 214 091 880 Bytes
  • stripped binary size 711 255 088 Bytes

merge: 7083a1b ydbd build size:

  • binary size 9 214 096 664 Bytes
  • stripped binary size 711 255 408 Bytes

ydbd size dashboard

@pixcc pixcc merged commit 5ecaf1b into ydb-platform:main Jun 19, 2024
8 of 12 checks passed
pixcc added a commit to pixcc/ydb that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants