YQL-18490 remove HasRunningAsyncOperation from mkql_grace_join.cpp #4952

lll-phill-lll · 2024-05-28T19:33:18Z

Changelog entry

HasRunningAsyncOperation from mkql_grace_join.cpp to avoid races. Checking status of spiller should be enough.
...

Changelog category

Improvement

Additional information

...

github-actions · 2024-05-28T19:34:42Z

⚪ 2024-05-28 19:34:41 UTC Pre-commit check for a0416cf has started.
⚪ 2024-05-28 19:37:07 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-28 19:40:03 UTC Build successful.
⚪ 2024-05-28 19:40:14 UTC Tests are running...
🟢 2024-05-28 21:32:23 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
70920	58213	0	0	12702	5

github-actions · 2024-05-28T19:36:49Z

⚪ 2024-05-28 19:36:49 UTC Pre-commit check for a0416cf has started.
⚪ 2024-05-28 19:39:24 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-28 19:42:18 UTC Build successful.
⚪ 2024-05-28 19:42:31 UTC Tests are running...
🔴 2024-05-28 21:40:57 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11797	11701	0	35	53	8

github-actions · 2024-05-28T19:36:54Z

⚪ 2024-05-28 19:36:53 UTC Pre-commit check for a0416cf has started.
⚪ 2024-05-28 19:39:26 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-28 19:42:48 UTC Build successful.

github-actions · 2024-05-29T08:25:32Z

⚪ 2024-05-29 08:25:31 UTC Pre-commit check for 8b430f2 has started.
⚪ 2024-05-29 08:28:04 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-29 08:29:41 UTC Build failed. see the build logs.
🔴 2024-05-29 08:29:42 UTC Tests run skipped.

github-actions · 2024-05-29T08:28:22Z

⚪ 2024-05-29 08:28:22 UTC Pre-commit check for 8b430f2 has started.
⚪ 2024-05-29 08:30:57 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-29 08:32:34 UTC Build failed. see the build logs.

github-actions · 2024-05-29T08:31:14Z

⚪ 2024-05-29 08:31:14 UTC Pre-commit check for 8b430f2 has started.
⚪ 2024-05-29 08:33:44 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-29 08:35:21 UTC Build failed. see the build logs.
🔴 2024-05-29 08:35:22 UTC Tests run skipped.

github-actions · 2024-05-29T11:55:13Z

⚪ 2024-05-29 11:55:13 UTC Pre-commit check for e947293 has started.
⚪ 2024-05-29 11:57:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-29 12:13:11 UTC Build successful.
⚪ 2024-05-29 12:13:27 UTC Tests are running...
🔴 2024-05-29 14:20:53 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14483	14368	0	42	59	14

github-actions · 2024-05-29T11:56:23Z

⚪ 2024-05-29 11:56:23 UTC Pre-commit check for e947293 has started.
⚪ 2024-05-29 11:59:00 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-29 12:15:27 UTC Build successful.

github-actions · 2024-05-29T11:56:34Z

⚪ 2024-05-29 11:56:34 UTC Pre-commit check for e947293 has started.
⚪ 2024-05-29 11:59:12 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-29 12:11:04 UTC Build successful.
⚪ 2024-05-29 12:11:17 UTC Tests are running...
🔴 2024-05-29 14:13:29 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
73608	60893	0	3	12705	7

github-actions · 2024-05-29T22:57:33Z

⚪ 2024-05-29 22:57:33 UTC Pre-commit check for 234e72e has started.
⚪ 2024-05-29 23:00:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-29 23:03:09 UTC Build successful.
⚪ 2024-05-29 23:03:20 UTC Tests are running...
🔴 2024-05-30 00:53:41 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
73572	60825	0	21	12708	18

github-actions · 2024-05-29T22:57:59Z

⚪ 2024-05-29 22:57:59 UTC Pre-commit check for 234e72e has started.
⚪ 2024-05-29 23:00:33 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-29 23:03:29 UTC Build successful.
⚪ 2024-05-29 23:03:40 UTC Tests are running...
🔴 2024-05-30 00:45:39 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14406	14290	0	46	60	10

github-actions · 2024-05-29T22:58:04Z

⚪ 2024-05-29 22:58:04 UTC Pre-commit check for 234e72e has started.
⚪ 2024-05-29 23:00:43 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-29 23:04:21 UTC Build successful.

github-actions · 2024-05-30T10:21:32Z

⚪ 2024-05-30 10:21:32 UTC Pre-commit check for 56c2149 has started.
⚪ 2024-05-30 10:23:56 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-30 11:00:31 UTC Build successful.

github-actions · 2024-05-30T10:32:59Z

⚪ 2024-05-30 10:32:58 UTC Pre-commit check for 56c2149 has started.
⚪ 2024-05-30 10:35:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-30 11:07:45 UTC Build successful.
⚪ 2024-05-30 11:07:54 UTC Tests are running...
🔴 2024-05-30 13:03:47 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
70871	58140	0	9	12708	14

github-actions · 2024-05-30T10:44:32Z

⚪ 2024-05-30 10:44:31 UTC Pre-commit check for 56c2149 has started.
⚪ 2024-05-30 10:47:02 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-30 11:23:47 UTC Build successful.
⚪ 2024-05-30 11:23:58 UTC Tests are running...
🔴 2024-05-30 13:08:50 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11713	11604	0	46	48	15

lll-phill-lll requested a review from a team as a code owner May 28, 2024 19:33

github-actions bot added the new-feature label May 28, 2024

lll-phill-lll changed the title ~~refactoring~~ YQL-18490 remove HasRunningAsyncOperation from gracejoin spilling May 28, 2024

refactoring

ba930c2

lll-phill-lll force-pushed the YQL-18490-gracejoin-spilling-get-rid-of-asynciooperations branch from 0b0bdf5 to ba930c2 Compare May 29, 2024 08:21

fix conflicts

d3f19d0

seems to works

a6eed35

fixed all tests

fcbd4b9

lll-phill-lll requested a review from a team as a code owner May 29, 2024 22:54

lll-phill-lll added 5 commits May 30, 2024 12:25

removed prints

c0b0759

small refactoring

a5b4208

disable spilling

08e3737

fixup

f305792

fixup

cc8c8f6

lll-phill-lll requested a review from Darych May 30, 2024 10:17

Darych approved these changes May 30, 2024

View reviewed changes

lll-phill-lll changed the title ~~YQL-18490 remove HasRunningAsyncOperation from gracejoin spilling~~ YQL-18490 remove HasRunningAsyncOperation from mkql_grace_join.cpp May 30, 2024

github-actions bot added the improvement label May 30, 2024

lll-phill-lll merged commit 60e1b89 into ydb-platform:main May 30, 2024

GrigoriyPA mentioned this pull request May 31, 2024

Fixed build error in TForgetScriptExecutionOperationQueryActor #5084

Merged

StekPerepolnen mentioned this pull request May 31, 2024

vdisk evict #5093

Merged

GrigoriyPA mentioned this pull request Jun 3, 2024

Fixed backward compatibility in fq-proxy result_writer_actor #5111

Merged

This was referenced Jun 6, 2024

Mute split by load ut #5264

Closed

Mute split by load ut #5267

Closed

Mute split by load ut #5272

Merged

Fix build #5310

Merged

serbel324 mentioned this pull request Jun 7, 2024

Don't mark slow disks if there is only one #5340

Merged

GrigoriyPA mentioned this pull request Jun 10, 2024

KqpRun fixed performance and backtrace printing #5368

Merged

niksaveliev mentioned this pull request Jun 10, 2024

Fix split by load ut #5383

Merged

This was referenced Jun 11, 2024

metadata cache keeps merged issues #5461

Merged

json_hc metadata cache #5465

Merged

GrigoriyPA mentioned this pull request Jun 13, 2024

YQ-3333 added yql syntax for creating resource pools #5498

Merged

This was referenced Jun 14, 2024

json tenantinfo status metadata cache #5543

Merged

json query transaction mode #5574

Merged

niksaveliev mentioned this pull request Jun 17, 2024

Fix win build #5622

Closed

StekPerepolnen mentioned this pull request Jun 19, 2024

hc api doc #5703

Merged

This was referenced Jun 19, 2024

WM passed resource pool settings to user request context #5734

Merged

YQ splitted fq/s3/test_s3.py tests #5798

Merged

This was referenced Jun 23, 2024

move time difference issue under database level #5859

Merged

metadata requests flags fix #5860

Merged

oidc-proxy new iam 2 #6059

Merged

YQL-18490 remove HasRunningAsyncOperation from mkql_grace_join.cpp #4952

YQL-18490 remove HasRunningAsyncOperation from mkql_grace_join.cpp #4952

Uh oh!

Conversation

lll-phill-lll commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog entry

Changelog category

Additional information

Uh oh!

github-actions bot commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lll-phill-lll commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading