Skip to content

Fix blocks optimization #4899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2024
Merged

Fix blocks optimization #4899

merged 2 commits into from
May 27, 2024

Conversation

@nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented May 27, 2024

Changelog entry

Fix Block Sort optimization

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@nikvas0 nikvas0 requested a review from gridnevvvit May 27, 2024 15:29
@github-actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

⚪ 2024-05-27 15:40:58 UTC Pre-commit check for 3afbdbe has started.
⚪ 2024-05-27 15:43:27 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-27 15:45:49 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

⚪ 2024-05-27 15:41:02 UTC Pre-commit check for 3afbdbe has started.
⚪ 2024-05-27 15:43:39 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-27 15:46:23 UTC Build successful.
⚪ 2024-05-27 15:46:35 UTC Tests are running...
🔴 2024-05-27 17:46:15 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9413 9322 0 34 41 16

@github-actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

⚪ 2024-05-27 15:41:14 UTC Pre-commit check for 3afbdbe has started.
⚪ 2024-05-27 15:43:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-27 15:46:08 UTC Build successful.
⚪ 2024-05-27 15:46:23 UTC Tests are running...
🔴 2024-05-27 16:55:48 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13413 12096 0 13 1299 5

nepal
nepal reviewed May 27, 2024
View reviewed changes
ydb/core/kqp/opt/kqp_opt_build_txs.cpp
.Add(CreateKqpTxPeepholeTransformer(TypeAnnTransformer.Get(), typesCtx, config, /* withFinalStageRules */ false, {"KqpPeephole-RewriteCrossJoin"}), "Peephole")
.Add(CreateKqpTxPeepholeTransformer(
TypeAnnTransformer.Get(), typesCtx, config,
/* withFinalStageRules */ config->BlockChannelsMode == NKikimrConfig::TTableServiceConfig_EBlockChannelsMode_BLOCK_CHANNELS_FORCE,
Copy link
Collaborator

@nepal nepal May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я бы тут ставил true если BlockChannelsMode != SCALAR || BlockEngineMode != DISABLE
Т.е. наличие вайдовых/блочных каналов или блочных вычислений должно включать эту стадию

@nikvas0 nikvas0 merged commit fec3196 into ydb-platform:main May 27, 2024
@GrigoriyPA GrigoriyPA mentioned this pull request May 28, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
This was referenced Jun 19, 2024
Merged
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nepal nepal nepal left review comments

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikvas0 @nepal @gridnevvvit