Skip to content

YQ-3157 enable batch script results by size #4860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2024
Merged

YQ-3157 enable batch script results by size #4860

merged 2 commits into from
May 28, 2024

Conversation

@GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented May 25, 2024 •
edited
Loading

Changelog entry

Enable script result batching by size

Changelog category

  • Improvement

Additional information

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner May 25, 2024 13:50
@GrigoriyPA GrigoriyPA requested a review from dorooleg May 25, 2024 13:51
@github-actions
Copy link

github-actions bot commented May 25, 2024 •
edited
Loading

⚪ 2024-05-25 13:52:20 UTC Pre-commit check for 895d102 has started.
⚪ 2024-05-25 13:54:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-25 13:56:05 UTC Build successful.
⚪ 2024-05-25 13:56:18 UTC Tests are running...
🔴 2024-05-25 15:46:47 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9260 9198 0 20 26 16

@github-actions
Copy link

github-actions bot commented May 25, 2024 •
edited
Loading

⚪ 2024-05-25 13:53:03 UTC Pre-commit check for 895d102 has started.
⚪ 2024-05-25 13:55:30 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-25 13:57:02 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 25, 2024 •
edited
Loading

⚪ 2024-05-25 13:54:08 UTC Pre-commit check for 895d102 has started.
⚪ 2024-05-25 13:56:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-25 13:58:23 UTC Build successful.
⚪ 2024-05-25 13:58:38 UTC Tests are running...
🔴 2024-05-25 15:31:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
36606 31816 0 4 4779 7

uzhastik
uzhastik previously approved these changes May 28, 2024
View reviewed changes
dorooleg
dorooleg reviewed May 28, 2024
View reviewed changes
ydb/core/fq/libs/compute/ydb/ydb_connector_actor.cpp Outdated
void Handle(const TEvYdbCompute::TEvFetchScriptResultRequest::TPtr& ev) {
NYdb::NQuery::TFetchScriptResultsSettings settings;
settings.FetchToken(ev->Get()->FetchToken);
settings.RowsLimit(0);
Copy link
Collaborator

@dorooleg dorooleg May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему он в connector ушел? его нужно в result writer пропихивать

Copy link
Collaborator

@dorooleg dorooleg May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connector это общая компонента которая может в других местах использоваться

@GrigoriyPA GrigoriyPA requested a review from dorooleg May 28, 2024 10:49
@github-actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 10:56:27 UTC Pre-commit check for e98c40c has started.
⚫ 2024-05-28 10:58:06 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 10:57:36 UTC Pre-commit check for e98c40c has started.
⚫ 2024-05-28 10:58:01 UTC Check cancelled

@GrigoriyPA GrigoriyPA force-pushed the YQ-3157-enable-batch-script-results-by-size branch from caf64cf to ff97289 Compare May 28, 2024 10:57
@github-actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 11:02:53 UTC Pre-commit check for e1d0972 has started.
⚪ 2024-05-28 11:05:07 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-28 11:07:06 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 11:07:15 UTC Pre-commit check for e1d0972 has started.
⚪ 2024-05-28 11:10:12 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-28 11:12:46 UTC Build successful.
⚪ 2024-05-28 11:12:55 UTC Tests are running...
🔴 2024-05-28 13:02:17 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9275 9203 0 19 29 24

@github-actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 11:10:13 UTC Pre-commit check for e1d0972 has started.
⚪ 2024-05-28 11:12:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-28 11:14:43 UTC Build successful.
⚪ 2024-05-28 11:14:54 UTC Tests are running...
🔴 2024-05-28 12:42:51 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
36646 31853 0 2 4779 12

@GrigoriyPA GrigoriyPA merged commit 8bca55f into ydb-platform:main May 28, 2024
@GrigoriyPA GrigoriyPA deleted the YQ-3157-enable-batch-script-results-by-size branch May 28, 2024 14:10
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request May 28, 2024
@GrigoriyPA
YQ-3157 enable batch script results by size (ydb-platform#4860)
c08a35f
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
This was referenced Jun 6, 2024
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
This was referenced Jun 19, 2024
Merged
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dorooleg dorooleg dorooleg approved these changes

@uzhastik uzhastik uzhastik left review comments

Assignees

No one assigned

Labels

improvement new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GrigoriyPA @dorooleg @uzhastik