switch health check to storage sys views #4848

vporyadke · 2024-05-24T15:56:34Z

Changelog entry

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

...

github-actions · 2024-05-24T16:24:16Z

⚪ 2024-05-24 16:24:16 UTC Pre-commit check for c5dc3bb has started.
⚪ 2024-05-24 16:26:36 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-24 16:29:04 UTC Build successful.
⚪ 2024-05-24 16:29:17 UTC Tests are running...
🔴 2024-05-24 18:14:33 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9456	9374	0	21	44	17

github-actions · 2024-05-24T16:27:45Z

⚪ 2024-05-24 16:27:45 UTC Pre-commit check for c5dc3bb has started.
⚪ 2024-05-24 16:30:16 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-24 16:32:52 UTC Build successful.
⚪ 2024-05-24 16:33:01 UTC Tests are running...
🔴 2024-05-24 17:51:17 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13580	12266	0	2	1303	9

github-actions · 2024-05-24T16:28:48Z

⚪ 2024-05-24 16:28:48 UTC Pre-commit check for c5dc3bb has started.
⚪ 2024-05-24 16:31:07 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-24 16:33:16 UTC Build successful.

…fixes

github-actions · 2024-05-26T22:14:20Z

⚪ 2024-05-26 22:14:20 UTC Pre-commit check for adaafdd has started.
⚪ 2024-05-26 22:16:48 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-26 22:19:15 UTC Build successful.

github-actions · 2024-05-26T22:14:35Z

⚪ 2024-05-26 22:14:35 UTC Pre-commit check for adaafdd has started.
⚪ 2024-05-26 22:17:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-26 22:19:35 UTC Build successful.
⚪ 2024-05-26 22:19:52 UTC Tests are running...
🔴 2024-05-26 23:29:33 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13580	12268	0	4	1300	8

github-actions · 2024-05-26T22:14:35Z

⚪ 2024-05-26 22:14:35 UTC Pre-commit check for adaafdd has started.
⚪ 2024-05-26 22:17:02 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-26 22:19:44 UTC Build successful.
⚪ 2024-05-26 22:19:56 UTC Tests are running...
🔴 2024-05-27 00:06:15 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9454	9404	0	18	23	9

github-actions · 2024-05-28T18:45:40Z

⚪ 2024-05-28 18:45:40 UTC Pre-commit check for 5f0df7c has started.
⚪ 2024-05-28 18:48:10 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-28 18:51:03 UTC Build successful.

github-actions · 2024-05-28T18:45:45Z

⚪ 2024-05-28 18:45:44 UTC Pre-commit check for 5f0df7c has started.
⚪ 2024-05-28 18:48:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-28 18:50:43 UTC Build successful.
⚪ 2024-05-28 18:50:59 UTC Tests are running...
🟢 2024-05-28 20:02:00 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13613	12309	0	0	1299	5

github-actions · 2024-05-28T18:45:51Z

⚪ 2024-05-28 18:45:50 UTC Pre-commit check for 5f0df7c has started.
⚪ 2024-05-28 18:48:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-28 18:52:00 UTC Build successful.
⚪ 2024-05-28 18:52:24 UTC Tests are running...
🔴 2024-05-28 20:47:08 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9459	9406	0	18	24	11

StekPerepolnen · 2024-05-28T15:09:12Z

ydb/core/health_check/health_check.cpp

-            }
+        context.Location.mutable_storage()->mutable_pool()->mutable_group()->mutable_vdisk()->mutable_pdisk()->begin()->set_path(pDisk.GetPath());
+        const auto& status = pDisk.GetStatusV2();
+        if (status == "ACTIVE") {


I would recommend avoiding direct comparisons with strings and instead converting string values to enum, as this reduces the likelihood of errors.

StekPerepolnen · 2024-05-29T12:22:50Z

ydb/core/health_check/health_check.cpp

-                                    {ETags::PDiskSpace});
-                break;
-        }*/
+        if (spaceStatus != Ydb::Monitoring::StatusFlag::GREEN) {


I'm not sure the first record will have the necessary PDiskSpace tag; it could be PDiskState as well

There is well hidden ReportWithMaxChildStatus method
I think you can use it like
ReportWithMaxChildStatus("VDisk have space issue", ETags::VDiskState, ETags::PDiskSpace});
instead

github-actions · 2024-05-29T15:42:40Z

⚪ 2024-05-29 15:42:40 UTC Pre-commit check for 682aa90 has started.
⚪ 2024-05-29 15:45:07 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-29 15:49:16 UTC Build successful.
⚪ 2024-05-29 15:49:28 UTC Tests are running...
🔴 2024-05-29 17:40:47 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9471	9411	0	26	23	11

github-actions · 2024-05-29T15:56:09Z

⚪ 2024-05-29 15:56:09 UTC Pre-commit check for 682aa90 has started.
⚪ 2024-05-29 15:58:43 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-29 16:02:38 UTC Build successful.

github-actions · 2024-05-29T16:02:29Z

⚪ 2024-05-29 16:02:28 UTC Pre-commit check for 682aa90 has started.
⚪ 2024-05-29 16:04:56 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-29 16:07:25 UTC Build successful.
⚪ 2024-05-29 16:07:39 UTC Tests are running...
🟢 2024-05-29 17:17:11 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13625	12320	0	0	1299	6

switch health check to storage sys views

ad03d4b

github-actions bot added the not-for-changelog label May 24, 2024

some more cleaning up

25b176f

ressurect the logic of requesting static group if its state is bad + …

577ff18

…fixes

vporyadke self-assigned this May 27, 2024

adameat requested review from StekPerepolnen and adameat May 28, 2024 04:53

adameat previously approved these changes May 28, 2024

View reviewed changes

tie pdisk space issues to vdisks

ad7b54b

vporyadke dismissed adameat’s stale review via ad7b54b May 28, 2024 18:42

StekPerepolnen reviewed May 29, 2024

View reviewed changes

fixes

b14e3c0

StekPerepolnen approved these changes May 30, 2024

View reviewed changes

vporyadke merged commit 2309d52 into ydb-platform:main May 30, 2024

This was referenced May 30, 2024

Added ExecutionId for script execution logs #5014

Merged

Fixed build error in TForgetScriptExecutionOperationQueryActor #5084

Merged

StekPerepolnen mentioned this pull request May 31, 2024

vdisk evict #5093

Merged

GrigoriyPA mentioned this pull request Jun 3, 2024

Fixed backward compatibility in fq-proxy result_writer_actor #5111

Merged

This was referenced Jun 6, 2024

Mute split by load ut #5264

Closed

Mute split by load ut #5267

Closed

Mute split by load ut #5272

Merged

Fix build #5310

Merged

serbel324 mentioned this pull request Jun 7, 2024

Don't mark slow disks if there is only one #5340

Merged

GrigoriyPA mentioned this pull request Jun 10, 2024

KqpRun fixed performance and backtrace printing #5368

Merged

niksaveliev mentioned this pull request Jun 10, 2024

Fix split by load ut #5383

Merged

This was referenced Jun 11, 2024

metadata cache keeps merged issues #5461

Merged

json_hc metadata cache #5465

Merged

GrigoriyPA mentioned this pull request Jun 13, 2024

YQ-3333 added yql syntax for creating resource pools #5498

Merged

This was referenced Jun 14, 2024

json tenantinfo status metadata cache #5543

Merged

json query transaction mode #5574

Merged

niksaveliev mentioned this pull request Jun 17, 2024

Fix win build #5622

Closed

StekPerepolnen mentioned this pull request Jun 19, 2024

hc api doc #5703

Merged

This was referenced Jun 19, 2024

WM passed resource pool settings to user request context #5734

Merged

YQ splitted fq/s3/test_s3.py tests #5798

Merged

This was referenced Jun 23, 2024

move time difference issue under database level #5859

Merged

metadata requests flags fix #5860

Merged

oidc-proxy new iam 2 #6059

Merged

switch health check to storage sys views #4848

switch health check to storage sys views #4848

Uh oh!

Conversation

vporyadke commented May 24, 2024

Changelog entry

Changelog category

Additional information

Uh oh!

github-actions bot commented May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StekPerepolnen May 28, 2024

Choose a reason for hiding this comment

Uh oh!

StekPerepolnen May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented May 24, 2024 •

edited

Loading

github-actions bot commented May 24, 2024 •

edited

Loading

github-actions bot commented May 24, 2024 •

edited

Loading

github-actions bot commented May 26, 2024 •

edited

Loading

github-actions bot commented May 26, 2024 •

edited

Loading

github-actions bot commented May 26, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

StekPerepolnen May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading